Bug 231188 - [clang 13] Suppress sign comparison warnings
Summary: [clang 13] Suppress sign comparison warnings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-04 12:16 PDT by Basuke Suzuki
Modified: 2021-10-19 12:50 PDT (History)
12 users (show)

See Also:

Attachments
Patch (1.64 KB, patch)
2021-10-19 10:54 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Basuke Suzuki 2021-10-04 12:16:10 PDT 
C:/PSDev/webkit/Source/JavaScriptCore\inspector/remote/socket/RemoteInspectorSocket.cpp:273:68: warning: comparison of integers of different signs: 'int' and 'unsigned long' [-Wsign-compare]
        if (FileSystem::readFromFile(handle, buffer.data(), *size) == *size)
            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~~
1 warning generated.
Comment 1 Radar WebKit Bug Importer 2021-10-11 12:17:24 PDT 
<rdar://problem/84110570>
Comment 2 Chris Dumez 2021-10-19 10:54:08 PDT 
Created attachment 441756 [details]
Patch
Comment 3 EWS 2021-10-19 12:49:58 PDT 
Committed r284480 (243239@main): <https://commits.webkit.org/243239@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 441756 [details].