Bug 231186 - Don't use namespace WebCore::XPath at global scope
Summary: Don't use namespace WebCore::XPath at global scope
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks: 231302
  Show dependency tree / graph
 
Reported: 2021-10-04 11:53 PDT by Alex Christensen
Modified: 2021-10-06 11:02 PDT (History)
4 users (show)

See Also:

Attachments
Patch (4.52 KB, patch)
2021-10-04 11:55 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2021-10-04 11:53:36 PDT 
Don't use namespace WebCore::XPath at global scope
Comment 1 Alex Christensen 2021-10-04 11:55:14 PDT 
Created attachment 440084 [details]
Patch
Comment 2 Basuke Suzuki 2021-10-04 11:57:30 PDT 
I'm checking right now.
Comment 3 Basuke Suzuki 2021-10-04 12:47:35 PDT 
In PlayStation port, it still has these compile errors:

C:/PSDev/webkit/Source/WebCore/platform/graphics\Path.h:140:58: error: expected ')'
    bool strokeContains(const FloatPoint&, const Function<void(GraphicsContext&)>& strokeStyleApplier) const;
                                                         ^
C:/PSDev/webkit/Source/WebCore/platform/graphics\Path.h:140:24: note: to match this '('
    bool strokeContains(const FloatPoint&, const Function<void(GraphicsContext&)>& strokeStyleApplier) const;
                       ^
C:/PSDev/webkit/Source/WebCore/platform/graphics\Path.h:146:48: error: expected ')'
    FloatRect strokeBoundingRect(const Function<void(GraphicsContext&)>& strokeStyleApplier = { }) const;
                                               ^
C:/PSDev/webkit/Source/WebCore/platform/graphics\Path.h:146:33: note: to match this '('
    FloatRect strokeBoundingRect(const Function<void(GraphicsContext&)>& strokeStyleApplier = { }) const;
                                ^
2 errors generated.
Comment 4 Ross Kirsling 2021-10-04 15:46:45 PDT 
Perhaps the issue is the remaining `using namespace`s at XPathGrammar.y:51?
Comment 5 EWS 2021-10-06 11:00:09 PDT 
Committed r283635 (242586@main): <https://commits.webkit.org/242586@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 440084 [details].
Comment 6 Radar WebKit Bug Importer 2021-10-06 11:01:22 PDT 
<rdar://problem/83942126>