RESOLVED FIXED 231186
Don't use namespace WebCore::XPath at global scope 
https://bugs.webkit.org/show_bug.cgi?id=231186
Summary Don't use namespace WebCore::XPath at global scope
Alex Christensen
Reported 2021-10-04 11:53:36 PDT
Don't use namespace WebCore::XPath at global scope
Attachments
Patch (4.52 KB, patch)
2021-10-04 11:55 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2021-10-04 11:55:14 PDT
Created attachment 440084 [details] Patch
Basuke Suzuki
Comment 2 2021-10-04 11:57:30 PDT
I'm checking right now.
Basuke Suzuki
Comment 3 2021-10-04 12:47:35 PDT
In PlayStation port, it still has these compile errors: C:/PSDev/webkit/Source/WebCore/platform/graphics\Path.h:140:58: error: expected ')' bool strokeContains(const FloatPoint&, const Function<void(GraphicsContext&)>& strokeStyleApplier) const; ^ C:/PSDev/webkit/Source/WebCore/platform/graphics\Path.h:140:24: note: to match this '(' bool strokeContains(const FloatPoint&, const Function<void(GraphicsContext&)>& strokeStyleApplier) const; ^ C:/PSDev/webkit/Source/WebCore/platform/graphics\Path.h:146:48: error: expected ')' FloatRect strokeBoundingRect(const Function<void(GraphicsContext&)>& strokeStyleApplier = { }) const; ^ C:/PSDev/webkit/Source/WebCore/platform/graphics\Path.h:146:33: note: to match this '(' FloatRect strokeBoundingRect(const Function<void(GraphicsContext&)>& strokeStyleApplier = { }) const; ^ 2 errors generated.
Ross Kirsling
Comment 4 2021-10-04 15:46:45 PDT
Perhaps the issue is the remaining `using namespace`s at XPathGrammar.y:51?
EWS
Comment 5 2021-10-06 11:00:09 PDT
Committed r283635 (242586@main): <https://commits.webkit.org/242586@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 440084 [details].
Radar WebKit Bug Importer
Comment 6 2021-10-06 11:01:22 PDT
<rdar://problem/83942126>
Note You need to log in before you can comment on or make changes to this bug.