Bug 231179 - Fix wrong edge type from get-by-val in 32 bits
Summary: Fix wrong edge type from get-by-val in 32 bits
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-04 11:00 PDT by Mikhail R. Gadelha
Modified: 2021-10-06 00:16 PDT (History)
9 users (show)

See Also:

Attachments
Patch (4.44 KB, patch)
2021-10-04 11:09 PDT, Mikhail R. Gadelha 		no flags Details | Formatted Diff | Diff
Patch (7.97 KB, patch)
2021-10-05 13:57 PDT, Mikhail R. Gadelha 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail R. Gadelha 2021-10-04 11:00:02 PDT 
Fix wrong edge type from get-by-val in 32 bits
Comment 1 Mikhail R. Gadelha 2021-10-04 11:09:11 PDT 
Created attachment 440079 [details]
Patch
Comment 2 Yusuke Suzuki 2021-10-05 10:57:51 PDT 
Comment on attachment 440079 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440079&action=review

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp:4518
> +        JSValueOperand baseOperand(this, baseEdge);
> +        generate(baseOperand.gpr());

base is JSValue, but it only passes payload part of JSValue. In 32bit, there is tag part, which needs to be passed. If it is a JSValue, then we need to use JSValueRegs.
Comment 3 Mikhail R. Gadelha 2021-10-05 13:57:08 PDT 
Created attachment 440260 [details]
Patch
Comment 4 Yusuke Suzuki 2021-10-05 17:52:42 PDT 
Comment on attachment 440260 [details]
Patch

r=me
Comment 5 EWS 2021-10-06 00:15:45 PDT 
Committed r283603 (242555@main): <https://commits.webkit.org/242555@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 440260 [details].
Comment 6 Radar WebKit Bug Importer 2021-10-06 00:16:17 PDT 
<rdar://problem/83921689>