Bug 231168 - Re-import html/semantics/forms/ WPT
Summary: Re-import html/semantics/forms/ WPT
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Nguyen (:ntim)
URL:
Keywords: InRadar
Depends on: 231217
Blocks: 203139
  Show dependency tree / graph
 
Reported: 2021-10-04 07:32 PDT by Tim Nguyen (:ntim)
Modified: 2021-10-04 23:44 PDT (History)
4 users (show)

See Also:

Attachments
Patch (532.30 KB, patch)
2021-10-04 08:13 PDT, Tim Nguyen (:ntim) 		no flags Details | Formatted Diff | Diff
Patch (559.92 KB, patch)
2021-10-04 08:24 PDT, Tim Nguyen (:ntim) 		no flags Details | Formatted Diff | Diff
Patch (137.35 KB, patch)
2021-10-04 09:00 PDT, Tim Nguyen (:ntim) 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (138.82 KB, patch)
2021-10-04 14:32 PDT, Tim Nguyen (:ntim) 		ntim: commit-queue-
Details | Formatted Diff | Diff
Patch (138.71 KB, patch)
2021-10-04 14:52 PDT, Tim Nguyen (:ntim) 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Nguyen (:ntim) 2021-10-04 07:32:55 PDT 
Make sure this test suite is up-to-date before implementing new autofocus behaviour.
Comment 1 Radar WebKit Bug Importer 2021-10-04 07:33:21 PDT 
<rdar://problem/83835125>
Comment 2 Tim Nguyen (:ntim) 2021-10-04 08:13:42 PDT 
Created attachment 440063 [details]
Patch
Comment 3 Tim Nguyen (:ntim) 2021-10-04 08:24:59 PDT 
Created attachment 440065 [details]
Patch
Comment 4 youenn fablet 2021-10-04 08:27:54 PDT 
View in context: https://bugs.webkit.org/attachment.cgi?id=440063&action=review

> LayoutTests/imported/w3c/ChangeLog:11
> +        * resources/resource-files.json:

It seems strange to have this massive changes here.
For import-expectations, if bots are happy, this seems good.
For slow tests, I am not sure, worth reverting these changes except if we are sure these WPT tests are no longer slow as per their metadata tag.

> LayoutTests/tests-options.json:-14
> -    "imported/w3c/css/css-color/color-resolving-hsl.html": [

I am not clear why all these tests are no longer slow.
Comment 5 youenn fablet 2021-10-04 08:28:33 PDT 
Comment on attachment 440065 [details]
Patch

r=me once bots are happy and we either revert the changes to slow expectations or we validate the tests are no longer slow.
Comment 6 Tim Nguyen (:ntim) 2021-10-04 09:00:48 PDT 
Created attachment 440067 [details]
Patch
Comment 7 Tim Nguyen (:ntim) 2021-10-04 14:32:40 PDT 
Created attachment 440104 [details]
Patch
Comment 8 Tim Nguyen (:ntim) 2021-10-04 14:52:57 PDT 
Created attachment 440108 [details]
Patch
Comment 9 EWS 2021-10-04 16:44:16 PDT 
Committed r283525 (242492@main): <https://commits.webkit.org/242492@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 440108 [details].