Bug 231140 - Use ScrollClamping in more places in scrolling code
Summary: Use ScrollClamping in more places in scrolling code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Scrolling (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-03 11:41 PDT by Simon Fraser (smfr)
Modified: 2021-10-04 16:39 PDT (History)
15 users (show)

See Also:

Attachments
Patch (19.54 KB, patch)
2021-10-03 11:43 PDT, Simon Fraser (smfr) 		koivisto: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2021-10-03 11:41:36 PDT 
Use ScrollClamping in more places in scrolling code
Comment 1 Simon Fraser (smfr) 2021-10-03 11:43:10 PDT 
Created attachment 440010 [details]
Patch
Comment 2 Antti Koivisto 2021-10-04 10:42:55 PDT 
Comment on attachment 440010 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440010&action=review

> Source/WebCore/platform/ScrollableArea.h:400
> -    unsigned m_constrainsScrollingToContentEdge : 1;
> +    unsigned m_scrollClamping : 1; // ScrollClamping
>  
>      unsigned m_inLiveResize : 1;

These should be regular typed fields instead of bitfields. We don't have enough ScrollAreas for its size to matter.

They should then be initialized here instead of constructor.
Comment 3 Simon Fraser (smfr) 2021-10-04 16:38:36 PDT 
https://trac.webkit.org/changeset/283524/webkit
Comment 4 Radar WebKit Bug Importer 2021-10-04 16:39:46 PDT 
<rdar://problem/83861580>