WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
231140
Use ScrollClamping in more places in scrolling code
https://bugs.webkit.org/show_bug.cgi?id=231140
Summary
Use ScrollClamping in more places in scrolling code
Simon Fraser (smfr)
Reported
2021-10-03 11:41:36 PDT
Use ScrollClamping in more places in scrolling code
Attachments
Patch
(19.54 KB, patch)
2021-10-03 11:43 PDT
,
Simon Fraser (smfr)
koivisto
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1
2021-10-03 11:43:10 PDT
Created
attachment 440010
[details]
Patch
Antti Koivisto
Comment 2
2021-10-04 10:42:55 PDT
Comment on
attachment 440010
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=440010&action=review
> Source/WebCore/platform/ScrollableArea.h:400 > - unsigned m_constrainsScrollingToContentEdge : 1; > + unsigned m_scrollClamping : 1; // ScrollClamping > > unsigned m_inLiveResize : 1;
These should be regular typed fields instead of bitfields. We don't have enough ScrollAreas for its size to matter. They should then be initialized here instead of constructor.
Simon Fraser (smfr)
Comment 3
2021-10-04 16:38:36 PDT
https://trac.webkit.org/changeset/283524/webkit
Radar WebKit Bug Importer
Comment 4
2021-10-04 16:39:46 PDT
<
rdar://problem/83861580
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug