Bug 231125 – Share more code that uses ScratchRegisterAllocator in the ICs

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Saam Barati]

A bunch of similar code. We can just share things.

[Radar WebKit Bug Importer]

<rdar://problem/84066374>

[Saam Barati]

Created attachment 440825 [details]
patch

[Justin Michaud]

Comment on attachment 440825 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440825&action=review

> Source/JavaScriptCore/bytecode/PolymorphicAccess.cpp:256
> +ScratchRegisterAllocator AccessGenerationState::makeDefaultScratchAllocator(GPRReg extraToLock)

Cool, LGTM

[Sam Weinig]

Comment on attachment 440825 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440825&action=review

> Source/JavaScriptCore/bytecode/AccessCase.cpp:1681
> +        ScratchRegisterAllocator allocator = state.makeDefaultScratchAllocator(scratchGPR);

In other parts of WebKit, we would use auto here, since the function makes it exceedingly clear what the type is, but I'm not sure where JSC is on that these days.

[Saam Barati]

Comment on attachment 440825 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440825&action=review

>> Source/JavaScriptCore/bytecode/AccessCase.cpp:1681
>> +        ScratchRegisterAllocator allocator = state.makeDefaultScratchAllocator(scratchGPR);
> 
> In other parts of WebKit, we would use auto here, since the function makes it exceedingly clear what the type is, but I'm not sure where JSC is on that these days.

I'm happy to use "auto" in these cases.

[Saam Barati]

Created attachment 440838 [details]
patch for landing

[EWS]

Committed r283954 (242805@main): <https://commits.webkit.org/242805@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 440838 [details].