Bug 231112 - Some layout tests with Japanese glyphs fail if Japanese is included in the system "Preferred Languages" settings
Summary: Some layout tests with Japanese glyphs fail if Japanese is included in the sy...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-01 16:47 PDT by Simon Fraser (smfr)
Modified: 2021-10-03 10:11 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.31 KB, patch)
2021-10-01 18:40 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2021-10-01 16:47:20 PDT 
I had Japanse in my list of "Preferred Languages" in the Language & Region system settings on Big Sur, and this causes a subset of layout tests to fail, including:
fast/ruby/ruby-justification.html
fast/text/backslash-to-yen-sign-euc.html
and tests with "ideograph" in the name.

We need to fix WTR to make tests pass independently of system language settings.
Comment 1 Myles C. Maxfield 2021-10-01 17:36:39 PDT 
I can reproduce this.
Comment 2 Myles C. Maxfield 2021-10-01 17:38:25 PDT 
Fixing DRT would be super difficult (bordering on "impossible") here. Fixing WKTR is probably not very difficult. We already have infrastructure for mocking the system font. We probably should just always enable that infrastructure.
Comment 3 Myles C. Maxfield 2021-10-01 18:40:45 PDT 
Created attachment 439946 [details]
Patch
Comment 4 EWS 2021-10-03 10:10:52 PDT 
Committed r283468 (242445@main): <https://commits.webkit.org/242445@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 439946 [details].
Comment 5 Radar WebKit Bug Importer 2021-10-03 10:11:19 PDT 
<rdar://problem/83815251>