Bug 231100 - [LFC][IFC] Pass in the correct style when adding a run to Line
Summary: [LFC][IFC] Pass in the correct style when adding a run to Line
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-01 13:56 PDT by zalan
Modified: 2021-10-02 06:52 PDT (History)
5 users (show)

See Also:

Attachments
Patch (3.71 KB, patch)
2021-10-01 13:58 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (3.62 KB, patch)
2021-10-02 06:15 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2021-10-01 13:56:16 PDT 
first-line
Comment 1 zalan 2021-10-01 13:58:29 PDT 
Created attachment 439907 [details]
Patch
Comment 2 Antti Koivisto 2021-10-02 05:35:44 PDT 
Comment on attachment 439907 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439907&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:821
> +        auto& style = [&] () -> const RenderStyle& {
> +            return m_isFirstLine ? inlineItem.firstLineStyle() : inlineItem.style();
> +        }();

Not sure if there is such a thing as overuse of lambda but this might be one.
Comment 3 zalan 2021-10-02 06:15:37 PDT 
Created attachment 439964 [details]
Patch
Comment 4 EWS 2021-10-02 06:51:54 PDT 
Committed r283442 (242429@main): <https://commits.webkit.org/242429@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 439964 [details].
Comment 5 Radar WebKit Bug Importer 2021-10-02 06:52:16 PDT 
<rdar://problem/83797765>