Bug 231096 - Enable PCM debug mode per WebsiteDataStore instead of process-global
Summary: Enable PCM debug mode per WebsiteDataStore instead of process-global
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-01 13:29 PDT by Alex Christensen
Modified: 2021-10-05 10:26 PDT (History)
2 users (show)

See Also:

Attachments
Patch (19.88 KB, patch)
2021-10-01 13:30 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (19.91 KB, patch)
2021-10-02 16:17 PDT, Alex Christensen 		katherine_cheney: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2021-10-01 13:29:15 PDT 
Enable PCM debug mode per WebsiteDataStore instead of process-global
Comment 1 Alex Christensen 2021-10-01 13:30:12 PDT 
Created attachment 439903 [details]
Patch
Comment 2 Alex Christensen 2021-10-02 16:17:48 PDT 
Created attachment 439977 [details]
Patch
Comment 3 Kate Cheney 2021-10-04 09:28:03 PDT 
Comment on attachment 439977 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439977&action=review

LGTM

> Source/WebKit/NetworkProcess/NetworkSession.cpp:431
> +    auto message = enabled ? "[Private Click Measurement] Turned Debug Mode on."_s : "[Private Click Measurement] Turned Debug Mode off."_s;

Seems like there was an isEphemeral() check in the previous code that got lost here, not sure how important that is.
Comment 4 Alex Christensen 2021-10-04 09:59:05 PDT 
Comment on attachment 439977 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439977&action=review

>> Source/WebKit/NetworkProcess/NetworkSession.cpp:431
>> +    auto message = enabled ? "[Private Click Measurement] Turned Debug Mode on."_s : "[Private Click Measurement] Turned Debug Mode off."_s;
> 
> Seems like there was an isEphemeral() check in the previous code that got lost here, not sure how important that is.

Yeah, it's just for broadcasting debug messages to the web inspector, and we now only broadcast to the current session, which effectively does the same thing.
Comment 5 Alex Christensen 2021-10-04 10:39:00 PDT 
Comment on attachment 439977 [details]
Patch

http://trac.webkit.org/r283504
Comment 6 Radar WebKit Bug Importer 2021-10-04 11:04:03 PDT 
<rdar://problem/83843839>
Comment 7 Alex Christensen 2021-10-04 11:48:14 PDT 
I manually verified this on macOS.
Comment 8 Alex Christensen 2021-10-05 10:26:35 PDT 
I manually verified this on iOS also.