Bug 23109 – REGRESSION: Backwards search in a long document matches incorrectly

• Status: RESOLVED
• Resolution: FIXED
• Component: Text

To reproduce:
1) Go to the URL
2) Choose Edit > Find > Find
3) In the search field, type "display"
4) Click the previous match button near the search field

Note that the highlighted text is not the word "display".

[Darin Adler]

Should be simple to fix. I'll look at it tomorrow.

[Darin Adler]

Given the structure of the code, it's quite surprising that searching forward works properly and searching backward fails.

[Darin Adler]

Created attachment 26425 [details]
patch

[Darin Adler]

http://trac.webkit.org/changeset/39609

[Simon Hausmann]

I'd like to note that on a build _without_ the ICU based SearchBuffer the backwards search results in an endless loop, including in the changeset's testcase fast/text/find-backwards.html. It looks like the goto inserted in the last hunk triggers this, but I don't know the code well enough to be sure it's really the goto's fault or just a symptom.

(In reply to comment #5)
> I'd like to note that on a build _without_ the ICU based SearchBuffer the
> backwards search results in an endless loop, including in the changeset's
> testcase fast/text/find-backwards.html. It looks like the goto inserted in the
> last hunk triggers this, but I don't know the code well enough to be sure it's
> really the goto's fault or just a symptom.

Please file a new bug.

[Darin Adler]

And please cc me. I'll be happy to take a crack at fixing it.