Bug 231086 - Begin migration from WTF::Variant to std::variant
Summary: Begin migration from WTF::Variant to std::variant
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-01 10:56 PDT by Alex Christensen
Modified: 2021-10-12 08:47 PDT (History)
58 users (show)

See Also:

Attachments
Patch (189.82 KB, patch)
2021-10-01 10:57 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (159.77 KB, patch)
2021-10-01 15:08 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (164.36 KB, patch)
2021-10-03 14:54 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
Patch (163.92 KB, patch)
2021-10-03 17:15 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
Patch (168.11 KB, patch)
2021-10-04 14:12 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (162.49 KB, patch)
2021-10-04 16:39 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (86.77 KB, patch)
2021-10-11 18:04 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (6) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2021-10-01 10:56:53 PDT 
Begin migration from WTF::Variant to std::variant
Comment 1 Alex Christensen 2021-10-01 10:57:52 PDT 
Created attachment 439878 [details]
Patch
Comment 2 Alex Christensen 2021-10-01 15:08:42 PDT 
Created attachment 439916 [details]
Patch
Comment 3 Alex Christensen 2021-10-01 16:26:09 PDT 
I'd appreciate it if someone could get this compiling on Windows and/or Linux.  I think I've done the bulk of the work, but this is a bit much for iterating on EWS.  The biggest thing was that visitor lambdas need to return the exact same type now.
Comment 4 Fujii Hironori 2021-10-03 14:54:33 PDT 
Created attachment 440020 [details]
Patch
Comment 5 Fujii Hironori 2021-10-03 17:15:52 PDT 
Created attachment 440027 [details]
Patch
Comment 6 Alex Christensen 2021-10-04 10:07:42 PDT 
Thanks, Fujii.  I added some linux developers who have recently contributed to WebKit.
Comment 7 Philippe Normand 2021-10-04 13:26:28 PDT 
GTK diff: http://sprunge.us/7UCiuf
Comment 8 Alex Christensen 2021-10-04 14:12:12 PDT 
Created attachment 440103 [details]
Patch
Comment 9 Alex Christensen 2021-10-04 16:39:22 PDT 
Created attachment 440123 [details]
Patch
Comment 10 Alex Christensen 2021-10-05 11:13:32 PDT 
split most of this out into https://bugs.webkit.org/show_bug.cgi?id=231239
Comment 11 Radar WebKit Bug Importer 2021-10-08 10:57:32 PDT 
<rdar://problem/84034814>
Comment 12 Alex Christensen 2021-10-11 18:04:10 PDT 
Created attachment 440867 [details]
Patch
Comment 13 EWS 2021-10-12 08:47:19 PDT 
Committed r283982 (242828@main): <https://commits.webkit.org/242828@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 440867 [details].