Bug 231075 – Attribute IOSurfaces created by camera and decoders to responsible WebProcess

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[youenn fablet]

Attribute IOSurfaces created by camera and decoders to responsible WebProcess

[youenn fablet]

Created attachment 439847 [details]
Patch

[EWS]

Committed r283369 (242378@main): <https://commits.webkit.org/242378@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 439847 [details].

[Radar WebKit Bug Importer]

<rdar://problem/83767168>

[David Kilzer (:ddkilzer)]

(In reply to EWS from comment #2)
> Committed r283369 (242378@main): <https://commits.webkit.org/242378@main>
> 
> All reviewed patches have been landed. Closing bug and clearing flags on
> attachment 439847 [details].

After the build failure from Bug X was fixed, I think (not 100% sure) this change is now causing a different build failure:

./platform/graphics/cocoa/IOSurface.mm:491:76: error: use of undeclared identifier 'kIOSurfaceMemoryLedgerTagGraphics'

<https://build.webkit.org/#/builders/275/builds/117>

It's the only recent change that uses HAVE(IOSURFACE_SET_OWNERSHIP_IDENTITY), as kIOSurfaceMemoryLedgerTagGraphics was added for Bug 220770 in r271673 last January.

[David Kilzer (:ddkilzer)]

(In reply to David Kilzer (:ddkilzer) from comment #4)
> (In reply to EWS from comment #2)
> > Committed r283369 (242378@main): <https://commits.webkit.org/242378@main>
> > 
> > All reviewed patches have been landed. Closing bug and clearing flags on
> > attachment 439847 [details].
> 
> After the build failure from Bug X was fixed,

And Bug X would be Bug 231034 and commit r283480.

[David Kilzer (:ddkilzer)]

(In reply to David Kilzer (:ddkilzer) from comment #4)
> (In reply to EWS from comment #2)
> > Committed r283369 (242378@main): <https://commits.webkit.org/242378@main>
> > 
> > All reviewed patches have been landed. Closing bug and clearing flags on
> > attachment 439847 [details].
> 
> After the build failure from Bug X was fixed, I think (not 100% sure) this
> change is now causing a different build failure:
> 
> ./platform/graphics/cocoa/IOSurface.mm:491:76: error: use of undeclared
> identifier 'kIOSurfaceMemoryLedgerTagGraphics'
> 
> <https://build.webkit.org/#/builders/275/builds/117>
> 
> It's the only recent change that uses
> HAVE(IOSURFACE_SET_OWNERSHIP_IDENTITY), as kIOSurfaceMemoryLedgerTagGraphics
> was added for Bug 220770 in r271673 last January.

I have a fix.

[David Kilzer (:ddkilzer)]

Reopening to attach new patch.

[David Kilzer (:ddkilzer)]

Created attachment 440021 [details]
Build fix

[David Kilzer (:ddkilzer)]

Comment on attachment 440021 [details]
Build fix

Waiting to mark cq+ until iOS, tvOS and watchOS builds are successful.

[David Kilzer (:ddkilzer)]

(In reply to David Kilzer (:ddkilzer) from comment #9)
> Comment on attachment 440021 [details]
> Build fix
> 
> Waiting to mark cq+ until iOS, tvOS and watchOS builds are successful.

Only the hardware builds need to succeed.  The simulator builds aren't failing.

[EWS]

Committed r283483 (242456@main): <https://commits.webkit.org/242456@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 440021 [details].