Bug 23106 – HTMLFormCollection::namedItem ignores caseSensitive argument

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Darin Adler]

I noticed this while looking at unused variable warnings.

[Darin Adler]

It turns out this has no effect because the only collection that ever gets passed false for caseSensitive is the anchors collection. A much better way to do that would be to add a findAnchor function to Document for the two call sites that need it.

[Darin Adler]

Created attachment 26426 [details]
patch

[Anders Carlsson]

Comment on attachment 26426 [details]
patch

r=me!

[Darin Adler]

http://trac.webkit.org/changeset/39603

[Adam Roben (:aroben)]

Comment on attachment 26426 [details]
patch

> +Element* Document::findAnchor(const String& name)
> +{
> +    if (name.isEmpty())
> +        return 0;
> +    if (Element* element = getElementById(name))
> +        return element;

Couldn't this return something other than an anchor element?

[Darin Adler]

(In reply to comment #5)
> Couldn't this return something other than an anchor element?

Yes. This function finds an "anchor", which is the site that a "#xxx" fragment navigates to; nowadays that can be any element with an ID although historically it could only be an anchor element.

If this function returned only anchor elements, I would have made its return type be HTMLAnchorElement instead of Element.