Bug 231055 – Python 3: run-inspector-generator-tests and generate-inspector-protocol-bindings.py

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Fujii Hironori]

Let's convert run-inspector-generator-tests and generate-inspector-protocol-bindings.py to Python 3.

[Fujii Hironori]

Created attachment 439810 [details]
Patch

[EWS Watchlist]

This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)

[Devin Rousso]

Can you explain why this needs to be done?  AFAICT none of the other inspector protocol python scripts are Python3?

[Jonathan Bedard]

(In reply to Devin Rousso from comment #3)
> Can you explain why this needs to be done?  AFAICT none of the other
> inspector protocol python scripts are Python3?

I think folks working on Windows are trying to drop Python 2 from their bots entirely.

[Don Olmstead]

(In reply to Jonathan Bedard from comment #4)
> (In reply to Devin Rousso from comment #3)
> > Can you explain why this needs to be done?  AFAICT none of the other
> > inspector protocol python scripts are Python3?
> 
> I think folks working on Windows are trying to drop Python 2 from their bots
> entirely.

Yea dropping Python 2 would be great but I also thought Python 2 was leaving OS X in a default install.

[Fujii Hironori]

(In reply to Devin Rousso from comment #3)
> Can you explain why this needs to be done?  AFAICT none of the other
> inspector protocol python scripts are Python3?

Because some Linux distributions don't allow packages to depends on Python 2, those scripts invokded while building WebKit have been Python 2&3 compatible since several years ago.
(Note that this patch isn't 2&3 compatible, and it is a test script.)

[Alexey Proskuryakov]

I think that at this point, we are just converting everything on every platform to python3, and completely ignoring python2 compatibility.

[Jonathan Bedard]

Comment on attachment 439810 [details]
Patch

We don't have this running in infrastructure anywhere, so this should be save to land

[Fujii Hironori]

Comment on attachment 439810 [details]
Patch

Thank you very much for the reveiw.

[EWS]

Committed r283682 (242620@main): <https://commits.webkit.org/242620@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 439810 [details].

[Radar WebKit Bug Importer]

<rdar://problem/83959145>