Bug 231052 - Stop parsing context-sensitive colors in override-color
Summary: Stop parsing context-sensitive colors in override-color
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks: 230446
  Show dependency tree / graph
 
Reported: 2021-09-30 17:45 PDT by Myles C. Maxfield
Modified: 2021-10-04 22:11 PDT (History)
11 users (show)

See Also:

Attachments
Patch (15.14 KB, patch)
2021-10-01 22:53 PDT, Myles C. Maxfield 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Radar WebKit Bug Importer 2021-09-30 17:45:34 PDT 
<rdar://problem/83746258>
Comment 2 Myles C. Maxfield 2021-10-01 22:53:30 PDT 
Created attachment 439954 [details]
Patch
Comment 3 EWS Watchlist 2021-10-01 22:54:55 PDT 
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Comment 4 Simon Fraser (smfr) 2021-10-04 20:52:14 PDT 
Comment on attachment 439954 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439954&action=review

> Source/WebCore/css/StyleColor.cpp:54
> +    return (id >= CSSValueAqua && id <= CSSValueYellow) || (id >= CSSValueAliceblue && id <= CSSValueYellowgreen) || id == CSSValueGrey || id == CSSValueAlpha || id == CSSValueTransparent;

We should make some helpers to contain these color range tests

> Source/WebCore/css/parser/CSSPropertyParserHelpers.h:118
> +enum class AcceptableColorSyntax : uint8_t {

Not sure I like "Acceptable" here. Might be nicer to just have:

enum class CSSColorType {
  Absolute = 1 << 0,
  Current = 1 << 1,
  System = 1 << 2,
};

consumeColor(CSSParserTokenRange&, const CSSParserContext&, bool acceptQuirkyColors = false, OptionSet<CSSColorTypes> allowedColorTypes)
Comment 5 Myles C. Maxfield 2021-10-04 22:11:06 PDT 
Committed r283537 (242502@main): <https://commits.webkit.org/242502@main>