Bug 23105 - canvas setFillColor function ignores alpha argument
Summary: canvas setFillColor function ignores alpha argument
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-04 10:28 PST by Darin Adler
Modified: 2009-03-02 11:51 PST (History)
2 users (show)

See Also:


Attachments
patch (15.17 KB, patch)
2009-01-04 21:25 PST, Darin Adler
oliver: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2009-01-04 10:28:30 PST
I noticed this while looking at unused argument warnings.
Comment 1 Darin Adler 2009-01-04 21:25:20 PST
Created attachment 26423 [details]
patch
Comment 2 Oliver Hunt 2009-01-04 23:22:52 PST
Comment on attachment 26423 [details]
patch

r=me, that's hilarious
Comment 3 Darin Adler 2009-01-04 23:25:45 PST
http://trac.webkit.org/changeset/39595
Comment 4 Simon Fraser (smfr) 2009-01-05 12:04:43 PST
fast/canvas/set-colors.html is failing now:
<http://build.webkit.org/results/trunk-mac-ppc-pixel/771/results.html>
Comment 5 Darin Adler 2009-01-05 13:09:24 PST
(In reply to comment #4)
> fast/canvas/set-colors.html is failing now:
> <http://build.webkit.org/results/trunk-mac-ppc-pixel/771/results.html>

There are two kinds of failures there:

    1) The CMYK conversion seems to be coming out slightly differently. I can either remove the CMYK test entirely or choose values for CMYK that give more consistent results.

    2) The very thing I was trying to fix seems to still be broken on Tiger!

I have no idea what to do about (2).
Comment 6 Darin Adler 2009-01-05 13:09:48 PST
I presume both of these failures are Tiger-only, because the tests are passing for me on Leopard machines.
Comment 7 Simon Fraser (smfr) 2009-01-05 13:15:03 PST
I saw a failure on my Leopard machine.

Does it depend on the screen color profile?
Comment 8 Simon Fraser (smfr) 2009-01-05 13:15:47 PST
Related to bug 22300?
Comment 9 Darin Adler 2009-01-05 13:17:09 PST
(In reply to comment #7)
> I saw a failure on my Leopard machine.

The same 5 failures as on the buildbot?

> Does it depend on the screen color profile?

It shouldn't. Perhaps it does.

I need to do something quick to get the buildbot green again. The big mystery is the setFillColor case, since that's the bug I was actually fixing!
Comment 10 Darin Adler 2009-01-05 13:25:40 PST
On my computer I am seeing the CMYK test failures both in Safari and in DumpRenderTree.

And I am seeing the setFillColor failure, but only in DumpRenderTree.
Comment 11 Darin Adler 2009-01-05 13:34:23 PST
All figured out. All fixed now.

http://trac.webkit.org/changeset/39612