Bug 231046 - [iOS] Add message filter in the WebContent process' sandbox
Summary: [iOS] Add message filter in the WebContent process' sandbox
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-09-30 16:30 PDT by Per Arne Vollan
Modified: 2021-10-11 01:14 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.59 KB, patch)
2021-09-30 16:35 PDT, Per Arne Vollan
no flags Details | Formatted Diff | Diff
Patch (1.58 KB, patch)
2021-10-11 00:19 PDT, Per Arne Vollan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2021-09-30 16:30:09 PDT
Add IOKit message filter in the WebContent process' sandbox on iOS.
Comment 1 Radar WebKit Bug Importer 2021-09-30 16:32:31 PDT
<rdar://problem/83743661>
Comment 2 Per Arne Vollan 2021-09-30 16:35:13 PDT
Created attachment 439793 [details]
Patch
Comment 3 Brent Fulgham 2021-10-01 09:27:59 PDT
Comment on attachment 439793 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439793&action=review

r=me

> Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:106
> +                (allow (with telemetry) iokit-external-method

Do we need telemetry on those two method numbers? Or should the telemetry be for any remaining denials?
Comment 4 Per Arne Vollan 2021-10-01 14:17:35 PDT
(In reply to Brent Fulgham from comment #3)
> Comment on attachment 439793 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=439793&action=review
> 
> r=me
> 
> > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:106
> > +                (allow (with telemetry) iokit-external-method
> 
> Do we need telemetry on those two method numbers? Or should the telemetry be
> for any remaining denials?

I think this rule will give us telemetry for both. Or am I mistaken?

Thanks for reviewing!
Comment 5 Per Arne Vollan 2021-10-11 00:19:50 PDT
Created attachment 440760 [details]
Patch
Comment 6 EWS 2021-10-11 01:14:46 PDT
Committed r283886 (242763@main): <https://commits.webkit.org/242763@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 440760 [details].