Bug 231044 – Allow NaN, infinity, and -infinity in calc

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Nikos Mouchtaris]

Allow NaN, infinity, and -infinity in calc

[Nikos Mouchtaris]

Created attachment 439792 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/83772269>

[Nikos Mouchtaris]

Created attachment 439910 [details]
Patch

[EWS Watchlist]

This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess

[Nikos Mouchtaris]

Created attachment 439914 [details]
Patch

[Nikos Mouchtaris]

Created attachment 439915 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 439915 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439915&action=review

> Source/WebCore/css/CSSPrimitiveValue.cpp:955
> +    if (m_value.num == -1*std::numeric_limits<double>::infinity())

Spaces around *

> Source/WebCore/css/CSSValueKeywords.in:1369
> +INFINITY

Why is this capitalized?

> Source/WebCore/css/calc/CSSCalcExpressionNodeParser.cpp:100
> +    return { { CSSValuePi, CSSUnitType::CSS_NUMBER, piDouble }, { CSSValueE, CSSUnitType::CSS_NUMBER, std::exp(1.0) }, { CSSValueInfinity, CSSUnitType::CSS_NUMBER, -1*std::numeric_limits<double>::infinity() }, { CSSValueINFINITY, CSSUnitType::CSS_NUMBER, std::numeric_limits<double>::infinity() }, { CSSValueNaN, CSSUnitType::CSS_NUMBER, std::numeric_limits<double>::quiet_NaN() } };

This need wrapping. CSSValueINFINITY is ugly.

[Simon Fraser (smfr)]

Comment on attachment 439915 [details]
Patch

r- for the -infinity confusion

[Nikos Mouchtaris]

Created attachment 439924 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 439924 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439924&action=review

> Source/WebCore/css/calc/CSSCalcExpressionNodeParser.cpp:103
> +    return { { CSSValuePi, CSSUnitType::CSS_NUMBER, piDouble }, { CSSValueE, CSSUnitType::CSS_NUMBER, std::exp(1.0) },
> +        { CSSValueNegativeInfinity, CSSUnitType::CSS_NUMBER, -1 * std::numeric_limits<double>::infinity() },
> +        { CSSValueInfinity, CSSUnitType::CSS_NUMBER, std::numeric_limits<double>::infinity() },
> +        { CSSValueNaN, CSSUnitType::CSS_NUMBER, std::numeric_limits<double>::quiet_NaN() } };

I would wrap this like:

return {
    { CSSValuePi, CSSUnitType::CSS_NUMBER, piDouble }, { CSSValueE, CSSUnitType::CSS_NUMBER, std::exp(1.0) },
    { CSSValueNegativeInfinity, CSSUnitType::CSS_NUMBER, -1 * std::numeric_limits<double>::infinity() },
    { CSSValueInfinity, CSSUnitType::CSS_NUMBER, std::numeric_limits<double>::infinity() },
    { CSSValueNaN, CSSUnitType::CSS_NUMBER, std::numeric_limits<double>::quiet_NaN() },
};

[Nikos Mouchtaris]

Created attachment 439947 [details]
infinity

[EWS]

Committed r283434 (242421@main): <https://commits.webkit.org/242421@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 439947 [details].

[Tim Nguyen (:ntim)]

*** Bug 219832 has been marked as a duplicate of this bug. ***