RESOLVED FIXED Bug 231023
[webkitscmpy] Generate commit message template 
https://bugs.webkit.org/show_bug.cgi?id=231023
Summary [webkitscmpy] Generate commit message template
Jonathan Bedard
Reported 2021-09-30 09:14:00 PDT
webkitscmpy should provide support for generating a prepare-commit-msg script. Although this change does not yet provide a replace for prepare-ChangeLog, it does allow us to leverage the existing script while decoupling that script from webkitscmpy.
Attachments
Patch (13.12 KB, patch)
2021-09-30 09:29 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (13.86 KB, patch)
2021-09-30 11:29 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (15.01 KB, patch)
2021-09-30 12:06 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (15.15 KB, patch)
2021-10-06 17:45 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (14.86 KB, patch)
2021-10-13 09:50 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (14.78 KB, patch)
2021-10-14 08:37 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.62 KB, patch)
2021-10-27 17:03 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-09-30 09:25:45 PDT
<rdar://problem/83722871>
Jonathan Bedard
Comment 2 2021-09-30 09:29:55 PDT
Created attachment 439744 [details] Patch
Jonathan Bedard
Comment 3 2021-09-30 10:36:16 PDT
The technique I'm using here is not exactly standard. We want to continue to have `git-webkit setup` be repository agnostic, but we also want repositories to be able to define their own commit message formats. In order to achieve this, we're essentially writing a Python file from scratch. But we would like to retain syntax high-lighting and style-checking for the generated code, which is where the `inspect` module comes in. What we're basically doing is defining a function, then extracting the source code of that function and putting it into the generated file. As an added wrinkle, in order of this to be repository agnostic, if the `git-webkit` entry-point would like to define a script to be used to generate the commit message, that script should be defined relative to `git-webkit`, not the generated script (which could be anywhere on a given machine)
Jonathan Bedard
Comment 4 2021-09-30 11:29:32 PDT
Created attachment 439761 [details] Patch
Jonathan Bedard
Comment 5 2021-09-30 12:06:27 PDT
Created attachment 439765 [details] Patch
Jonathan Bedard
Comment 6 2021-09-30 12:06:42 PDT
Pull-request: https://github.com/WebKit/WebKit/pull/13
Jonathan Bedard
Comment 7 2021-10-06 17:45:49 PDT
Created attachment 440460 [details] Patch
Jonathan Bedard
Comment 8 2021-10-13 09:50:03 PDT
Created attachment 441094 [details] Patch
Jonathan Bedard
Comment 9 2021-10-14 08:37:28 PDT
Created attachment 441219 [details] Patch
Jonathan Bedard
Comment 10 2021-10-19 13:14:14 PDT
Committed r284485 (243242@main): <https://commits.webkit.org/243242@main>
Jonathan Bedard
Comment 11 2021-10-19 13:36:44 PDT
Committed r284491 (243245@main): <https://commits.webkit.org/243245@main>
Jonathan Bedard
Comment 12 2021-10-27 17:03:49 PDT
Reopening to attach new patch.
Jonathan Bedard
Comment 13 2021-10-27 17:03:52 PDT
Created attachment 442653 [details] Patch for landing
EWS
Comment 14 2021-10-27 17:31:49 PDT
Committed r284966 (243617@main): <https://commits.webkit.org/243617@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 442653 [details].
Note You need to log in before you can comment on or make changes to this bug.