RESOLVED FIXED230995
[webkitpy] LOG_CHANNEL is widely used in the codebase and shouldn't be treated as error 
https://bugs.webkit.org/show_bug.cgi?id=230995
Summary [webkitpy] LOG_CHANNEL is widely used in the codebase and shouldn't be treate...
Basuke Suzuki
Reported 2021-09-29 15:45:38 PDT
This is the error. > python3 Tools/Scripts/check-webkit-style > in dir /Volumes/Data/worker/Style-EWS/build (timeout 1200 secs) > watching logfiles {} > argv: [b'python3', b'Tools/Scripts/check-webkit-style'] > using PTY: False > ERROR: Source/WTF/wtf/Assertions.h:203: LOG_CHANNEL is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] > ERROR: Source/WTF/wtf/Assertions.h:609: More than one command on the same line [whitespace/newline] [4] > Total errors found: 2 in 3 files > program finished with exit code 1 > elapsedTime=6.630763
Attachments
PATCH (1.55 KB, patch)
2021-09-29 15:51 PDT, Basuke Suzuki 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Basuke Suzuki
Comment 1 2021-09-29 15:51:46 PDT
Created attachment 439673 [details] PATCH
EWS
Comment 2 2021-09-29 16:53:39 PDT
Committed r283282 (242309@main): <https://commits.webkit.org/242309@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 439673 [details].
Radar WebKit Bug Importer
Comment 3 2021-09-29 16:54:23 PDT
<rdar://problem/83695013>
Note You need to log in before you can comment on or make changes to this bug.