Bug 230975 - Test a font palette identifier of just "--"
Summary: Test a font palette identifier of just "--"
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks: 230446
  Show dependency treegraph
 
Reported: 2021-09-29 11:55 PDT by Myles C. Maxfield
Modified: 2021-10-05 00:04 PDT (History)
6 users (show)

See Also:


Attachments
Patch (2.77 KB, patch)
2021-09-30 17:37 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Patch (4.78 KB, patch)
2021-10-01 16:21 PDT, Myles C. Maxfield
thorton: review+
Details | Formatted Diff | Diff
Patch for committing (4.97 KB, patch)
2021-10-04 23:11 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2021-09-29 11:55:14 PDT
It's a valid <dashed-ident>.
Comment 1 Radar WebKit Bug Importer 2021-09-29 11:55:36 PDT
<rdar://problem/83681811>
Comment 2 Myles C. Maxfield 2021-09-29 12:18:48 PDT
We should do this for both @font-palette-values and font-palette. These can be parsing tests.
Comment 3 Myles C. Maxfield 2021-09-30 17:37:09 PDT
Created attachment 439803 [details]
Patch
Comment 4 EWS Watchlist 2021-09-30 17:38:07 PDT
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Comment 5 Myles C. Maxfield 2021-10-01 16:21:13 PDT
Created attachment 439928 [details]
Patch
Comment 6 Myles C. Maxfield 2021-10-04 23:11:24 PDT
Created attachment 440162 [details]
Patch for committing
Comment 7 EWS 2021-10-05 00:04:23 PDT
Committed r283539 (242504@main): <https://commits.webkit.org/242504@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 440162 [details].