WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
230968
Cleaning up expectations for iOS 15
https://bugs.webkit.org/show_bug.cgi?id=230968
Summary
Cleaning up expectations for iOS 15
ayumi_kojima
Reported
2021-09-29 10:38:29 PDT
fast/form/ios tests are currently marked as [ Pass Failure Timeout Crash ] in iOS-14. fast/forms/ios/zoom-after-input-tap.html fast/forms/ios/zoom-after-input-tap-wide-input.html fast/forms/ios/focus-long-textarea.html fast/forms/ios/focus-input-via-button.html fast/forms/ios/focus-input-via-button-no-scaling.html fast/forms/ios/focus-input-in-iframe.html fast/forms/ios/focus-input-in-fixed.html fast/forms/ios/accessory-bar-navigation.html History:
https://results.webkit.org/?suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&test=fast%2Fforms%2Fios%2Fzoom-after-input-tap.html&test=fast%2Fforms%2Fios%2Fzoom-after-input-tap-wide-input.html&test=fast%2Fforms%2Fios%2Finputmode-none-with-hardware-keyboard.html&test=fast%2Fforms%2Fios%2Ffocus-long-textarea.html&test=fast%2Fforms%2Fios%2Ffocus-input-via-button.html&test=fast%2Fforms%2Fios%2Ffocus-input-via-button-no-scaling.html&test=fast%2Fforms%2Fios%2Ffocus-input-in-iframe.html&test=fast%2Fforms%2Fios%2Ffocus-input-in-fixed.html&test=fast%2Fforms%2Fios%2Faccessory-bar-navigation.html
The tests are initially marked as [ Pass Failure ] because they are intended to “fail or are flaky in non-internal iOS 14 simulator”
https://trac.webkit.org/changeset/281749/webkit
Later [ Timeout ] and [ Crash ] are added here
https://trac.webkit.org/changeset/281858/webkit
Apparently constant timeout seen on iPad is because iPads don't zoom when form elements are focused. The flaky crashes are not real crashes because of broken pipes (
Bug 230513
). Also, the constant failure and its diff indicate that the tests need rebaselining. Diff(iOS 14): --- /Volumes/Data/worker/ios-simulator-14-release-tests-wk2/build/layout-test-results/fast/forms/ios/focus-input-in-fixed-expected.txt +++ /Volumes/Data/worker/ios-simulator-14-release-tests-wk2/build/layout-test-results/fast/forms/ios/focus-input-in-fixed-actual.txt @@ -1,4 +1,4 @@ tap location { x: 40.000, y: 130.000 } scale 1.455 -visibleRect { left: 0.000, top: 44.683, width: 219.979, height: 376.713 } +visibleRect { left: 0.000, top: 0.000, width: 219.979, height: 376.713 }
Attachments
Update Expectations
(4.10 KB, patch)
2021-09-29 11:20 PDT
,
ayumi_kojima
no flags
Details
Formatted Diff
Diff
Update Expectations
(4.10 KB, patch)
2021-09-29 11:22 PDT
,
ayumi_kojima
no flags
Details
Formatted Diff
Diff
Update Expectations
(5.97 KB, patch)
2021-09-29 14:09 PDT
,
ayumi_kojima
tsavell
: review+
ews-feeder
: commit-queue-
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2021-09-29 10:38:53 PDT
<
rdar://problem/83677926
>
ayumi_kojima
Comment 2
2021-09-29 10:59:15 PDT
The numbers in the diffs found on the runs on iOS 14 and iOS 15 are the exact same, and local run on iOS 15 sim shows a different diff, I will hold off on rebaselining for now. Diff (iOS 15) --- /Volumes/Data/Builds/Star/ios/debugToTest/layout-test-results/fast/forms/ios/zoom-after-input-tap-expected.txt +++ /Volumes/Data/Builds/Star/ios/debugToTest/layout-test-results/fast/forms/ios/zoom-after-input-tap-actual.txt @@ -3,4 +3,4 @@ tap location { x: 38.000, y: 862.000 } scale 1.455 -visibleRect { left: 0.000, top: 776.799, width: 219.979, height: 376.713 } +visibleRect { left: 0.000, top: 655.820, width: 257.791, height: 444.775 }
ayumi_kojima
Comment 3
2021-09-29 11:20:56 PDT
Created
attachment 439630
[details]
Update Expectations
ayumi_kojima
Comment 4
2021-09-29 11:22:46 PDT
Created
attachment 439631
[details]
Update Expectations
ayumi_kojima
Comment 5
2021-09-29 14:09:36 PDT
Created
attachment 439654
[details]
Update Expectations
ayumi_kojima
Comment 6
2021-09-29 15:16:14 PDT
Created bugs to track some fast tests that are marked in iOS-14: fast/events/ios/viewport-shrink-to-fit-allows-double-tap.html (
Bug 230987
) fast/selectors/matches-backtracking.html (
Bug 230988
) fast/selectors/is-backtracking.html (
Bug 230988
)
EWS
Comment 7
2021-10-01 16:39:44 PDT
tsavell@apple.com
does not have reviewer permissions according to
https://raw.githubusercontent.com/WebKit/WebKit/main/metadata/contributors.json
. Rejecting
attachment 439654
[details]
from commit queue.
ayumi_kojima
Comment 8
2021-10-04 09:42:44 PDT
Updated expectations after Truitt's approval. Also, confirmed those tests need rebaselining on iOS 15. Added new expected files in iOS-15 folders:
https://trac.webkit.org/changeset/283500/webkit
ayumi_kojima
Comment 9
2021-10-04 15:51:49 PDT
Rebaselined fast/events/ios/keydown-keyup-keypress-keys-in-non-editable-using-chinese-keyboard.html:
https://trac.webkit.org/changeset/283520/webkit
ayumi_kojima
Comment 10
2021-10-05 10:40:25 PDT
https://trac.webkit.org/changeset/283523/webkit
ayumi_kojima
Comment 11
2021-10-07 14:02:01 PDT
Marked to skip http/tests/websocket/tests/hybi/bad-handshake-crash.html
https://trac.webkit.org/changeset/283741/webkit
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug