Bug 230947 - [CSS Cascade Layers] Add fonts and keyframes in cascade layer order
Summary: [CSS Cascade Layers] Add fonts and keyframes in cascade layer order
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antti Koivisto
URL:
Keywords: InRadar
Depends on:
Blocks: 220779
  Show dependency tree / graph
 
Reported: 2021-09-29 05:27 PDT by Antti Koivisto
Modified: 2021-09-29 08:24 PDT (History)
2 users (show)

See Also:

Attachments
Patch (12.05 KB, patch)
2021-09-29 05:38 PDT, Antti Koivisto 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (12.06 KB, patch)
2021-09-29 05:46 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2021-09-29 05:27:28 PDT 
Make sure font and keyframe rules respect cascade layer ordering.
Comment 1 Antti Koivisto 2021-09-29 05:38:01 PDT 
Created attachment 439598 [details]
Patch
Comment 2 Antti Koivisto 2021-09-29 05:46:15 PDT 
Created attachment 439599 [details]
Patch
Comment 3 Simon Fraser (smfr) 2021-09-29 07:44:46 PDT 
Comment on attachment 439599 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439599&action=review

> Source/WebCore/style/RuleSet.cpp:349
> +        if (is<StyleRuleFontFace>(*rule) || is<StyleRuleFontPaletteValues>(*rule) || is<StyleRuleKeyframes>(*rule)) {

Would be nice to have a way to collectively refer to these. Are they just all the kinds of @ rules we know about? What happens when we add new ones?
Comment 4 Antti Koivisto 2021-09-29 07:48:58 PDT 
> Would be nice to have a way to collectively refer to these. Are they just
> all the kinds of @ rules we know about? What happens when we add new ones?

Yeah, there is definitely room for cleanups and clarifications here.
Comment 5 EWS 2021-09-29 08:23:16 PDT 
Committed r283216 (242258@main): <https://commits.webkit.org/242258@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 439599 [details].
Comment 6 Radar WebKit Bug Importer 2021-09-29 08:24:40 PDT 
<rdar://problem/83671785>