RESOLVED FIXED 230947
[CSS Cascade Layers] Add fonts and keyframes in cascade layer order 
https://bugs.webkit.org/show_bug.cgi?id=230947
Summary [CSS Cascade Layers] Add fonts and keyframes in cascade layer order
Antti Koivisto
Reported 2021-09-29 05:27:28 PDT
Make sure font and keyframe rules respect cascade layer ordering.
Attachments
Patch (12.05 KB, patch)
2021-09-29 05:38 PDT, Antti Koivisto 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (12.06 KB, patch)
2021-09-29 05:46 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2021-09-29 05:38:01 PDT
Created attachment 439598 [details] Patch
Antti Koivisto
Comment 2 2021-09-29 05:46:15 PDT
Created attachment 439599 [details] Patch
Simon Fraser (smfr)
Comment 3 2021-09-29 07:44:46 PDT
Comment on attachment 439599 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=439599&action=review > Source/WebCore/style/RuleSet.cpp:349 > + if (is<StyleRuleFontFace>(*rule) || is<StyleRuleFontPaletteValues>(*rule) || is<StyleRuleKeyframes>(*rule)) { Would be nice to have a way to collectively refer to these. Are they just all the kinds of @ rules we know about? What happens when we add new ones?
Antti Koivisto
Comment 4 2021-09-29 07:48:58 PDT
> Would be nice to have a way to collectively refer to these. Are they just > all the kinds of @ rules we know about? What happens when we add new ones? Yeah, there is definitely room for cleanups and clarifications here.
EWS
Comment 5 2021-09-29 08:23:16 PDT
Committed r283216 (242258@main): <https://commits.webkit.org/242258@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 439599 [details].
Radar WebKit Bug Importer
Comment 6 2021-09-29 08:24:40 PDT
<rdar://problem/83671785>
Note You need to log in before you can comment on or make changes to this bug.