Bug 230933 - Reduce allocations in DatabaseUtilities::sortedTables
Summary: Reduce allocations in DatabaseUtilities::sortedTables
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-09-28 20:12 PDT by Alex Christensen
Modified: 2021-10-01 16:15 PDT (History)
3 users (show)

See Also:

Attachments
Patch (7.46 KB, patch)
2021-09-28 20:13 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2021-09-28 20:12:50 PDT 
Reduce allocations in DatabaseUtilities::sortedTables
Comment 1 Alex Christensen 2021-09-28 20:13:52 PDT 
Created attachment 439561 [details]
Patch
Comment 2 Chris Dumez 2021-09-28 20:21:49 PDT 
Comment on attachment 439561 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439561&action=review

> Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:276
> +Span<const ASCIILiteral> ResourceLoadStatisticsDatabaseStore::sortedTables()

Why return a span and not a const std::array<ASCIILiteral>& ?
Comment 3 Alex Christensen 2021-09-28 22:00:50 PDT 
Because they have different sizes.  std::array has a template parameter that is its size, so they would return different types.
Comment 4 EWS 2021-09-29 09:28:55 PDT 
Committed r283227 (242269@main): <https://commits.webkit.org/242269@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 439561 [details].
Comment 5 Radar WebKit Bug Importer 2021-09-29 09:29:20 PDT 
<rdar://problem/83674449>
Comment 6 Darin Adler 2021-10-01 16:12:43 PDT 
Comment on attachment 439561 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439561&action=review

> Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementDatabase.cpp:116
> +    static std::array sortedTables {

Why not constexpr?
Comment 7 Alex Christensen 2021-10-01 16:15:08 PDT 
Comment on attachment 439561 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439561&action=review

>> Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementDatabase.cpp:116
>> +    static std::array sortedTables {
> 
> Why not constexpr?

indeed.  That could be added.  I missed that.