RESOLVED FIXED 230931
Display return values in nicer way in the jsc REPL and add a prettyPrint function 
https://bugs.webkit.org/show_bug.cgi?id=230931
Summary Display return values in nicer way in the jsc REPL and add a prettyPrint func...
Saam Barati
Reported 2021-09-28 19:12:55 PDT
print strings with quotes around them, and arrays with brackets. Currently, print("[1]") looks like print("1") looks like print(1), which is not a great user experience.
Attachments
Patch (5.06 KB, patch)
2021-09-28 19:24 PDT, Saam Barati 		tzagallo: review+
DetailsFormatted DiffDiff
patch (9.07 KB, patch)
2021-09-29 10:23 PDT, Saam Barati 		tzagallo: review+
DetailsFormatted DiffDiff
patch for landing (10.23 KB, patch)
2021-09-29 13:50 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
patch (7.39 KB, patch)
2021-10-04 13:21 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2021-09-28 19:24:03 PDT
Created attachment 439555 [details] Patch
Saam Barati
Comment 2 2021-09-28 19:24:45 PDT
(In reply to Saam Barati from comment #0) > print strings with quotes around them, and arrays with brackets. > > Currently, print("[1]") looks like print("1") looks like print(1), which is > not a great user experience. I meant to say print([1]) for the first example.
Tadeu Zagallo
Comment 3 2021-09-28 19:26:54 PDT
Comment on attachment 439555 [details] Patch r=me
Saam Barati
Comment 4 2021-09-29 10:23:37 PDT
Created attachment 439621 [details] patch
Tadeu Zagallo
Comment 5 2021-09-29 10:25:14 PDT
Comment on attachment 439621 [details] patch r=me
Saam Barati
Comment 6 2021-09-29 13:50:01 PDT
Created attachment 439651 [details] patch for landing
EWS
Comment 7 2021-09-29 18:39:32 PDT
Committed r283293 (242318@main): <https://commits.webkit.org/242318@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 439651 [details].
Radar WebKit Bug Importer
Comment 8 2021-09-29 18:42:14 PDT
<rdar://problem/83698777>
Truitt Savell
Comment 9 2021-10-01 13:27:43 PDT
this patch broke 20 tes262 tests, tracking in https://bugs.webkit.org/show_bug.cgi?id=231095
WebKit Commit Bot
Comment 10 2021-10-01 23:46:35 PDT
Re-opened since this is blocked by bug 231116
Saam Barati
Comment 11 2021-10-04 13:21:03 PDT
Created attachment 440096 [details] patch
Tadeu Zagallo
Comment 12 2021-10-04 13:36:41 PDT
Comment on attachment 440096 [details] patch r=me
EWS
Comment 13 2021-10-04 17:34:06 PDT
Committed r283527 (242494@main): <https://commits.webkit.org/242494@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 440096 [details].
Note You need to log in before you can comment on or make changes to this bug.