Bug 230919 - Add telemetry to the Networking process sandbox
Summary: Add telemetry to the Networking process sandbox
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-09-28 14:49 PDT by Per Arne Vollan
Modified: 2021-09-29 13:07 PDT (History)
4 users (show)

See Also:

Attachments
Patch (33.07 KB, patch)
2021-09-28 14:51 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (33.10 KB, patch)
2021-09-28 14:55 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (32.27 KB, patch)
2021-09-29 10:08 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2021-09-28 14:49:09 PDT 
Add telemetry to the Networking process sandbox on iOS and macOS.
Comment 1 Radar WebKit Bug Importer 2021-09-28 14:49:37 PDT 
<rdar://problem/83641392>
Comment 2 Per Arne Vollan 2021-09-28 14:51:39 PDT 
Created attachment 439524 [details]
Patch
Comment 3 Per Arne Vollan 2021-09-28 14:55:40 PDT 
Created attachment 439526 [details]
Patch
Comment 4 Brent Fulgham 2021-09-29 09:56:46 PDT 
Comment on attachment 439526 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439526&action=review

It looks like you have a bad merge in this patch. Could you please rebase it?

> Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:55
> +(allow file-map-executable (with telemetry)

Did you mean to do telemetry for the Private Frameworks paths? Or just everything else?

> Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:415
> +<<<<<<< .mine

Uh oh! Bad merge!
Comment 5 Per Arne Vollan 2021-09-29 10:07:18 PDT 
(In reply to Brent Fulgham from comment #4)
> Comment on attachment 439526 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=439526&action=review
> 
> It looks like you have a bad merge in this patch. Could you please rebase it?
> 
> > Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:55
> > +(allow file-map-executable (with telemetry)
> 
> Did you mean to do telemetry for the Private Frameworks paths? Or just
> everything else?
> 

The intention was to add telemetry for all paths. Perhaps this was done incorrectly?

> > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:415
> > +<<<<<<< .mine
> 
> Uh oh! Bad merge!

Ah, will fix :)

Thanks for reviewing!
Comment 6 Per Arne Vollan 2021-09-29 10:08:17 PDT 
Created attachment 439619 [details]
Patch
Comment 7 Brent Fulgham 2021-09-29 10:18:11 PDT 
Comment on attachment 439619 [details]
Patch

r=me
Comment 8 Per Arne Vollan 2021-09-29 12:37:35 PDT 
Comment on attachment 439619 [details]
Patch

Thanks for reviewing!
Comment 9 EWS 2021-09-29 13:07:03 PDT 
Committed r283253 (242282@main): <https://commits.webkit.org/242282@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 439619 [details].