Bug 230889 - Fix rounding issue in run-jsc-stress-tests
Summary: Fix rounding issue in run-jsc-stress-tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-09-28 04:10 PDT by Geza Lore
Modified: 2021-09-28 05:45 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.28 KB, patch)
2021-09-28 04:17 PDT, Geza Lore 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Geza Lore 2021-09-28 04:10:54 PDT 
Fix rounding issue in run-jsc-stress-tests
Comment 1 Geza Lore 2021-09-28 04:17:51 PDT 
Created attachment 439455 [details]
Patch
Comment 2 Geza Lore 2021-09-28 04:22:09 PDT 
Sometimes ceil(N/K) == ceil(N/(K-1)), plus Ruby Array.slice gives you a nil if the start offset is past the end. This fixes the crashes arising when you did hit that rare combination of N (number of tests) and K (number of parallel processes).
Comment 3 EWS 2021-09-28 05:44:17 PDT 
Committed r283164 (242212@main): <https://commits.webkit.org/242212@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 439455 [details].
Comment 4 Radar WebKit Bug Importer 2021-09-28 05:45:16 PDT 
<rdar://problem/83619026>