Bug 230876 - [WTF] Add ApproximateTime
Summary: [WTF] Add ApproximateTime
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-09-27 18:54 PDT by Yusuke Suzuki
Modified: 2021-09-28 03:30 PDT (History)
15 users (show)

See Also:


Attachments
Patch (35.01 KB, patch)
2021-09-27 19:43 PDT, Yusuke Suzuki
fpizlo: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2021-09-27 18:54:29 PDT
[WTF] Add ApproximateTime
Comment 1 Yusuke Suzuki 2021-09-27 19:43:20 PDT
Created attachment 439427 [details]
Patch
Comment 2 Filip Pizlo 2021-09-27 20:12:18 PDT
Comment on attachment 439427 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439427&action=review

> Source/WTF/wtf/ApproximateTime.h:38
> +class ApproximateTime final {

Any reason why you didn't use the mixin approach that I had in my patch?
Comment 3 Yusuke Suzuki 2021-09-28 02:44:03 PDT
Comment on attachment 439427 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439427&action=review

I personally like ApproximateTime since that name shows the most error-prone thing related to this type: if we need non approximate time, then we should not use it.

>> Source/WTF/wtf/ApproximateTime.h:38
>> +class ApproximateTime final {
> 
> Any reason why you didn't use the mixin approach that I had in my patch?

Sounds good! Changed.
Comment 4 Yusuke Suzuki 2021-09-28 02:50:03 PDT
Committed r283161 (242209@main): <https://commits.webkit.org/242209@main>
Comment 5 Radar WebKit Bug Importer 2021-09-28 02:51:16 PDT
<rdar://problem/83614252>
Comment 6 Yusuke Suzuki 2021-09-28 03:30:06 PDT
Committed r283163 (242211@main): <https://commits.webkit.org/242211@main>