WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
23087
REGRESSION(
r39566
): Windows build fails due to undeclared FormState class.
https://bugs.webkit.org/show_bug.cgi?id=23087
Summary
REGRESSION(r39566): Windows build fails due to undeclared FormState class.
Brent Fulgham
Reported
2009-01-02 23:04:48 PST
The recent removal of the FormState.h header include from FrameLoader.h causes numerous Windows build errors. This is because MSVC is very finicky about declarations for smart pointers with forward class declarations. It generally wants access to the entire class declaration before it will allow a compile.
Attachments
Correct build error
(1.18 KB, patch)
2009-01-02 23:11 PST
,
Brent Fulgham
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Brent Fulgham
Comment 1
2009-01-02 23:11:56 PST
Created
attachment 26389
[details]
Correct build error
Mark Rowe (bdash)
Comment 2
2009-01-03 00:28:02 PST
Steve landed an identical change in
r39573
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug