Bug 230853 - Build-time optimization: forward declare more things in MediaPlayer.h and HTMLMediaElement.h
Summary: Build-time optimization: forward declare more things in MediaPlayer.h and HTM...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-09-27 12:24 PDT by Jer Noble
Modified: 2021-09-29 11:20 PDT (History)
25 users (show)

See Also:

Attachments
Patch (68.34 KB, patch)
2021-09-27 12:33 PDT, Jer Noble 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (79.66 KB, patch)
2021-09-27 15:29 PDT, Jer Noble 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (80.79 KB, patch)
2021-09-27 16:04 PDT, Jer Noble 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (80.65 KB, patch)
2021-09-27 16:46 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (81.64 KB, patch)
2021-09-28 11:16 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (83.23 KB, patch)
2021-09-28 15:06 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch for landing (82.71 KB, patch)
2021-09-29 09:28 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch for landing (82.72 KB, patch)
2021-09-29 10:34 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Show Obsolete (7) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2021-09-27 12:24:31 PDT 
Build-time optimization: forward declare more things in MediaPlayer.h and HTMLMediaElement.h
Comment 1 Jer Noble 2021-09-27 12:33:18 PDT 
Created attachment 439379 [details]
Patch
Comment 2 Jer Noble 2021-09-27 15:29:06 PDT 
Created attachment 439401 [details]
Patch
Comment 3 Eric Carlson 2021-09-27 15:58:29 PDT 
Comment on attachment 439401 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439401&action=review

r=me once the bots are happy

> Source/WebCore/ChangeLog:73
> +        * html/track/VideoTrackClient.h: Copied from Source/WebCore/Modules/encryptedmedia/legacy/LegacyCDMPrivateClearKey.cpp.

Nit: you should probably remove the auto-generated "Copied from Source/WebCore/Modules..." message as it isn't helpful.

> Source/WebCore/ChangeLog:85
> +        * platform/graphics/AudioTrackPrivateClient.h: Copied from Source/WebCore/Modules/encryptedmedia/legacy/LegacyCDMPrivateClearKey.cpp.

Ditto.

> Source/WebCore/ChangeLog:94
> +        * platform/graphics/TrackPrivateBaseClient.h: Copied from Source/WebCore/Modules/encryptedmedia/legacy/LegacyCDMPrivateClearKey.cpp.

Ditto.

> Source/WebCore/ChangeLog:98
> +        * platform/graphics/VideoTrackPrivateClient.h: Copied from Source/WebCore/Modules/encryptedmedia/legacy/LegacyCDMPrivateClearKey.cpp.

Ditto.
Comment 4 Jer Noble 2021-09-27 16:04:32 PDT 
Created attachment 439408 [details]
Patch
Comment 5 Jer Noble 2021-09-27 16:46:20 PDT 
Created attachment 439417 [details]
Patch
Comment 6 Jer Noble 2021-09-28 11:16:39 PDT 
Created attachment 439497 [details]
Patch

Reverted the change to RefPtr, as other compilers still throw errors for "RefPtr<Foo> foo() { return nullptr ; }" when Foo is forward-declared.
Comment 7 Jer Noble 2021-09-28 15:06:39 PDT 
Created attachment 439527 [details]
Patch
Comment 8 Jer Noble 2021-09-29 09:28:24 PDT 
Created attachment 439613 [details]
Patch for landing
Comment 9 EWS 2021-09-29 09:29:22 PDT 
Tools/Scripts/svn-apply failed to apply attachment 439613 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Comment 10 Jer Noble 2021-09-29 10:34:15 PDT 
Created attachment 439622 [details]
Patch for landing
Comment 11 EWS 2021-09-29 11:19:55 PDT 
Committed r283237 (242279@main): <https://commits.webkit.org/242279@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 439622 [details].
Comment 12 Radar WebKit Bug Importer 2021-09-29 11:20:24 PDT 
<rdar://problem/83680121>