Bug 230851 - Rename Style::queuePostResolutionCallback to Style::deprecatedQueuePostResolutionCallback
Summary: Rename Style::queuePostResolutionCallback to Style::deprecatedQueuePostResolu...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Nguyen (:ntim)
URL:
Keywords: InRadar
Depends on:
Blocks: 203139
  Show dependency treegraph
 
Reported: 2021-09-27 11:41 PDT by Tim Nguyen (:ntim)
Modified: 2021-09-27 14:22 PDT (History)
8 users (show)

See Also:


Attachments
Patch (5.09 KB, patch)
2021-09-27 11:53 PDT, Tim Nguyen (:ntim)
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Nguyen (:ntim) 2021-09-27 11:41:12 PDT
According to the WIP patch in bug 203139, the HTML 5 event loop should be used instead.
Comment 1 Tim Nguyen (:ntim) 2021-09-27 11:53:08 PDT
Created attachment 439375 [details]
Patch
Comment 2 Simon Fraser (smfr) 2021-09-27 12:01:10 PDT
Comment on attachment 439375 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439375&action=review

> Source/WebCore/style/StyleTreeResolver.h:115
> +void deprecatedQueuePostResolutionCallback(Function<void()>&&); // Integrate with the HTML5 event loop instead.

I think this comment could be more helpful. Where in the code should I do stuff instead of calling this function?
Comment 3 Tim Nguyen (:ntim) 2021-09-27 14:21:49 PDT
Committed r283134 (242191@main): <https://commits.webkit.org/242191@main>
Comment 4 Radar WebKit Bug Importer 2021-09-27 14:22:16 PDT
<rdar://problem/83591148>