RESOLVED FIXED230820
Remove ImplicitAddress 
https://bugs.webkit.org/show_bug.cgi?id=230820
Summary Remove ImplicitAddress
Saam Barati
Reported 2021-09-27 00:47:16 PDT
See what a gigantic waste of time I experienced in https://bugs.webkit.org/show_bug.cgi?id=229223 because of MSVC coercing regT0 to be nullptr instead of invoking the ImplicitAddress version of a function. We should just use Address(RegisterID) instead of relying on ImplicitAddress so we don't feel this pain in the future.
Attachments
test EWS (62.79 KB, patch)
2021-10-11 16:45 PDT, Saam Barati 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
test EWS (65.36 KB, patch)
2021-10-11 17:00 PDT, Saam Barati 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
test EWS (66.39 KB, patch)
2021-10-11 17:09 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
patch (67.66 KB, patch)
2021-10-11 18:55 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-10-04 00:48:20 PDT
<rdar://problem/83826318>
Saam Barati
Comment 2 2021-10-11 16:45:20 PDT
Created attachment 440859 [details] test EWS
Saam Barati
Comment 3 2021-10-11 17:00:32 PDT
Created attachment 440860 [details] test EWS
Saam Barati
Comment 4 2021-10-11 17:09:23 PDT
Created attachment 440863 [details] test EWS
Saam Barati
Comment 5 2021-10-11 18:55:38 PDT
Created attachment 440868 [details] patch
Yusuke Suzuki
Comment 6 2021-10-11 18:57:45 PDT
Comment on attachment 440868 [details] patch r=me if EWS is green.
EWS
Comment 7 2021-10-11 23:33:04 PDT
Committed r283970 (242817@main): <https://commits.webkit.org/242817@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 440868 [details].
Myles C. Maxfield
Comment 8 2021-10-12 01:02:55 PDT Comment hidden (obsolete)
Note You need to log in before you can comment on or make changes to this bug.