Bug 230820 - Remove ImplicitAddress
Summary: Remove ImplicitAddress
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-09-27 00:47 PDT by Saam Barati
Modified: 2021-10-12 01:02 PDT (History)
8 users (show)

See Also:

Attachments
test EWS (62.79 KB, patch)
2021-10-11 16:45 PDT, Saam Barati 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
test EWS (65.36 KB, patch)
2021-10-11 17:00 PDT, Saam Barati 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
test EWS (66.39 KB, patch)
2021-10-11 17:09 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
patch (67.66 KB, patch)
2021-10-11 18:55 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2021-09-27 00:47:16 PDT 
See what a gigantic waste of time I experienced in https://bugs.webkit.org/show_bug.cgi?id=229223 because of MSVC coercing regT0 to be nullptr instead of invoking the ImplicitAddress version of a function. We should just use Address(RegisterID) instead of relying on ImplicitAddress so we don't feel this pain in the future.
Comment 1 Radar WebKit Bug Importer 2021-10-04 00:48:20 PDT 
<rdar://problem/83826318>
Comment 2 Saam Barati 2021-10-11 16:45:20 PDT 
Created attachment 440859 [details]
test EWS
Comment 3 Saam Barati 2021-10-11 17:00:32 PDT 
Created attachment 440860 [details]
test EWS
Comment 4 Saam Barati 2021-10-11 17:09:23 PDT 
Created attachment 440863 [details]
test EWS
Comment 5 Saam Barati 2021-10-11 18:55:38 PDT 
Created attachment 440868 [details]
patch
Comment 6 Yusuke Suzuki 2021-10-11 18:57:45 PDT 
Comment on attachment 440868 [details]
patch

r=me if EWS is green.
Comment 7 EWS 2021-10-11 23:33:04 PDT 
Committed r283970 (242817@main): <https://commits.webkit.org/242817@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 440868 [details].
Comment 8 Myles C. Maxfield 2021-10-12 01:02:55 PDT Comment hidden (obsolete)