Bug 230803 – [JSC][32bit] Fix build after unlinked baseline JIT (r283083)

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Xan Lopez]

Bug #229223 broke 32-bit builds.

[Xan Lopez]

Created attachment 439734 [details]
WIP

This compiles/links/very basic stuff works, but it's still wrong and incomplete.

[Kevin Neal]

Thank you for filing. The appropriate engineers have been notified.

[Radar WebKit Bug Importer]

<rdar://problem/83739988>

[Xan Lopez]

Created attachment 439849 [details]
v1

[Xan Lopez]

Created attachment 439851 [details]
v2

Try to fix i386 build.

[Xan Lopez]

Created attachment 439855 [details]
v3

Add missing header to CMakeLists.txt

[Xan Lopez]

Created attachment 439857 [details]
v4

And another missing header... (RegisterMap.h)

[Saam Barati]

Comment on attachment 439857 [details]
v4

View in context: https://bugs.webkit.org/attachment.cgi?id=439857&action=review

Seems like a good first step to get things building. r=me

> Source/JavaScriptCore/bytecode/CallLinkInfo.h:28
> +#include "CallFrameShuffleData.h"

why was this needed. Why didn't the forward declare work?

> Source/JavaScriptCore/jit/JITInlines.h:369
> +    UNUSED_PARAM(value);
> +    UNUSED_PARAM(bytecode);
> +    // FIXME.

I think this can just be:
emitValueProfilingSite(valueProfileFor(bytecode.metadata(m_profiledCodeBlock), m_bytecodeIndex.checkpoint()), value);

> Source/JavaScriptCore/jit/JITOpcodes.cpp:1472
> +        loadGlobalObject(resultRegs.payloadGPR()); // FIXME: need to move the whole thing.

I think you just need:
move(TrustedImm32(CellTag), resultRegs.tagGPR())

[Xan Lopez]

(In reply to Saam Barati from comment #8)
> Comment on attachment 439857 [details]
> v4
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=439857&action=review
> 
> Seems like a good first step to get things building. r=me
> 
> > Source/JavaScriptCore/bytecode/CallLinkInfo.h:28
> > +#include "CallFrameShuffleData.h"
> 
> why was this needed. Why didn't the forward declare work?

std::unique_ptr was complaining, but I read in the spec that it explicitly allows for incomplete types. I'll try again.

[Xan Lopez]

Created attachment 439876 [details]
v5

patch to land

[Xan Lopez]

Created attachment 439877 [details]
v6

v6, patch to land (credit a couple of colleagues who helped with this patch)

[EWS]

Committed r283389 (242393@main): <https://commits.webkit.org/242393@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 439877 [details].