230773 – [ iOS ] CSS Flexbox tests are constant failure (fixed-table-layout-with-percentage-width-in-flex-item.html and flex-item-compressible-001.html)

Bug 230773 - [ iOS ] CSS Flexbox tests are constant failure (fixed-table-layout-with-percentage-width-in-flex-item.html and flex-item-compressible-001.html)

Summary: [ iOS ] CSS Flexbox tests are constant failure (fixed-table-layout-with-perce...

Status:	NEW

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	CSS (show other bugs)
Version:	WebKit Nightly Build
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Nobody

URL:
Keywords:	InRadar

Depends on:
Blocks:

Reported:	2021-09-24 14:50 PDT by Eric Hutchison
Modified:	2022-07-01 11:47 PDT (History)
CC List:	8 users (show)

See Also:

Attachments
Image Diff (4.63 KB, text/html) 2021-09-24 14:50 PDT, Eric Hutchison	no flags	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Eric Hutchison 2021-09-24 14:50:09 PDT

Created attachment 439200 [details]
Image Diff

imported/w3c/web-platform-tests/css/css-flexbox/fixed-table-layout-with-percentage-width-in-flex-item.html
imported/w3c/web-platform-tests/css/css-flexbox/flex-item-compressible-001.html

are constant failures on iOS.

History: https://results.webkit.org/?suite=layout-tests&suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-flexbox%2Ffixed-table-layout-with-percentage-width-in-flex-item.html&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-flexbox%2Fflex-item-compressible-001.html

Results: https://ews-build.s3-us-west-2.amazonaws.com/iOS-14-Simulator-WK2-Tests-EWS/r439143-21948-rerun/results.html

Diff: 
--- /Volumes/Data/worker/iOS-14-Simulator-WK2-Tests-EWS/build/layout-test-results/imported/w3c/web-platform-tests/css/css-flexbox/flex-item-compressible-001-expected.txt
+++ /Volumes/Data/worker/iOS-14-Simulator-WK2-Tests-EWS/build/layout-test-results/imported/w3c/web-platform-tests/css/css-flexbox/flex-item-compressible-001-actual.txt
@@ -22,14 +22,44 @@
 
 PASS .flexbox 1
 PASS .flexbox 2
-PASS .flexbox 3
-PASS .flexbox 4
-PASS .flexbox 5
+FAIL .flexbox 3 assert_equals:
+<div class="flexbox">
+      <div class="spacer"></div>
+      <input type="button" value="XXXXXXX" class="test1" data-expected-width="140">
+    </div>
+width expected 140 but got 180
+FAIL .flexbox 4 assert_equals:
+<div class="flexbox">
+      <div class="spacer"></div>
+      <input type="submit" value="XXXXXXX" class="test1" data-expected-width="140">
+    </div>
+width expected 140 but got 180
+FAIL .flexbox 5 assert_equals:
+<div class="flexbox">
+      <div class="spacer"></div>
+      <input type="reset" value="XXXXXXX" class="test1" data-expected-width="140">
+    </div>
+width expected 140 but got 180
 PASS .flexbox 6
 PASS .flexbox 7
-PASS .flexbox 8
-PASS .flexbox 9
-PASS .flexbox 10
+FAIL .flexbox 8 assert_equals:
+<div class="flexbox">
+      <div class="spacer"></div>
+      <input type="button" value="XXXXXXX" class="test2" data-expected-width="140">
+    </div>
+width expected 140 but got 180
+FAIL .flexbox 9 assert_equals:
+<div class="flexbox">
+      <div class="spacer"></div>
+      <input type="submit" value="XXXXXXX" class="test2" data-expected-width="140">
+    </div>
+width expected 140 but got 180
+FAIL .flexbox 10 assert_equals:
+<div class="flexbox">
+      <div class="spacer"></div>
+      <input type="reset" value="XXXXXXX" class="test2" data-expected-width="140">
+    </div>
+width expected 140 but got 180
 FAIL .flexbox 11 assert_equals:
 <div class="flexbox">
       <div class="spacer"></div>
@@ -42,7 +72,22 @@
       <input type="range" class="test3" data-expected-width="140">
     </div>
 width expected 140 but got 100
-PASS .flexbox 13
-PASS .flexbox 14
-PASS .flexbox 15
+FAIL .flexbox 13 assert_equals:
+<div class="flexbox">
+      <div class="spacer"></div>
+      <input type="button" value="XXXXXXX" class="test3" data-expected-width="140">
+    </div>
+width expected 140 but got 180
+FAIL .flexbox 14 assert_equals:
+<div class="flexbox">
+      <div class="spacer"></div>
+      <input type="submit" value="XXXXXXX" class="test3" data-expected-width="140">
+    </div>
+width expected 140 but got 180
+FAIL .flexbox 15 assert_equals:
+<div class="flexbox">
+      <div class="spacer"></div>
+      <input type="reset" value="XXXXXXX" class="test3" data-expected-width="140">
+    </div>
+width expected 140 but got 180
 

Image Diff attached. Found at: https://ews-build.s3-us-west-2.amazonaws.com/iOS-14-Simulator-WK2-Tests-EWS/r439143-21948-rerun/imported/w3c/web-platform-tests/css/css-flexbox/fixed-table-layout-with-percentage-width-in-flex-item-diffs.html

Issue was introduced at https://bugs.webkit.org/show_bug.cgi?id=230748 which was landed prior to EWS completing the test.

ref: https://bugs.webkit.org/show_bug.cgi?id=230748

Comment 1 Radar WebKit Bug Importer 2021-09-24 14:51:23 PDT

<rdar://problem/83512528>

Comment 2 Eric Hutchison 2021-09-24 14:58:02 PDT

Updated test expectations at https://trac.webkit.org/changeset/283060/webkit

Comment 3 ayumi_kojima 2021-10-07 11:20:28 PDT

imported/w3c/web-platform-tests/css/css-flexbox/fixed-table-layout-with-percentage-width-in-flex-item.html

Is still showing up as an image failure. Updated test expectations https://trac.webkit.org/changeset/283724/webkit

Comment 4 Hercules Hjalmarsson 2022-07-01 11:38:45 PDT

Pull request: https://github.com/WebKit/WebKit/pull/2000

Comment 5 EWS 2022-07-01 11:47:04 PDT

Test gardening commit 252058@main (34df2393809b): <https://commits.webkit.org/252058@main>

Reviewed commits have been landed. Closing PR #2000 and removing active labels.

Comment 6 Hercules Hjalmarsson 2022-07-01 11:47:39 PDT

(In reply to EWS from comment #5)
> Test gardening commit 252058@main (34df2393809b):
> <https://commits.webkit.org/252058@main>
> 
> Reviewed commits have been landed. Closing PR #2000 and removing active
> labels.

Remove expectations for flex-item-compressible-001.html in above commit.