Bug 230743 – IPC SimpleArgumentEncoder should static_assert(std::is_trivially_copyable<T>)

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Kimmo Kinnunen]

IPC SimpleArgumentEncoder should static_assert(std::is_trivially_copyable<T>)

[Radar WebKit Bug Importer]

<rdar://problem/83757335>

[Chris Dumez]

Created attachment 440250 [details]
Patch

[Kimmo Kinnunen]

Comment on attachment 440250 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440250&action=review

> Source/WebKit/Platform/IPC/ArgumentCoders.h:47
>      template<typename Encoder>

I think you should be able to assert once in the class scope.

template<typename T> struct SimpleArgumentCoder {
    static_assert(std::is_trivially_copyable_v<T>);
    ....

[Chris Dumez]

Created attachment 440364 [details]
Patch

[Chris Dumez]

(In reply to Kimmo Kinnunen from comment #3)
> Comment on attachment 440250 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=440250&action=review
> 
> > Source/WebKit/Platform/IPC/ArgumentCoders.h:47
> >      template<typename Encoder>
> 
> I think you should be able to assert once in the class scope.
> 
> template<typename T> struct SimpleArgumentCoder {
>     static_assert(std::is_trivially_copyable_v<T>);
>     ....

Indeed, fixed.

[EWS]

Kimmo Kinnunen found in /Volumes/Data/worker/Commit-Queue/build/Source/WebKit/ChangeLog does not appear to be a valid reviewer according to contributors.json.
/Volumes/Data/worker/Commit-Queue/build/Source/WebKit/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

[EWS]

Committed r283618 (242570@main): <https://commits.webkit.org/242570@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 440364 [details].