Bug 230732 - Move ScrollSnapAnimatorState's ScrollAnimationMomentum into ScrollingEffectsController
Summary: Move ScrollSnapAnimatorState's ScrollAnimationMomentum into ScrollingEffectsC...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Scrolling (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-09-23 17:21 PDT by Simon Fraser (smfr)
Modified: 2021-09-23 22:09 PDT (History)
4 users (show)

See Also:

Attachments
Patch (11.68 KB, patch)
2021-09-23 17:23 PDT, Simon Fraser (smfr) 		wenson_hsieh: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2021-09-23 17:21:22 PDT 
Move ScrollSnapAnimatorState's ScrollAnimationMomentum into ScrollingEffectsController
Comment 1 Simon Fraser (smfr) 2021-09-23 17:23:50 PDT 
Created attachment 439109 [details]
Patch
Comment 2 Wenson Hsieh 2021-09-23 17:28:54 PDT 
Comment on attachment 439109 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439109&action=review

> Source/WebCore/platform/ScrollingEffectsController.cpp:145
> +        m_currentAnimation = WTF::makeUnique<ScrollAnimationMomentum>(*this);

Nit - you can omit this `WTF::`
Comment 3 Simon Fraser (smfr) 2021-09-23 22:08:04 PDT 
https://trac.webkit.org/changeset/283026/webkit
Comment 4 Radar WebKit Bug Importer 2021-09-23 22:09:19 PDT 
<rdar://problem/83480219>