WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
230732
Move ScrollSnapAnimatorState's ScrollAnimationMomentum into ScrollingEffectsController
https://bugs.webkit.org/show_bug.cgi?id=230732
Summary
Move ScrollSnapAnimatorState's ScrollAnimationMomentum into ScrollingEffectsC...
Simon Fraser (smfr)
Reported
2021-09-23 17:21:22 PDT
Move ScrollSnapAnimatorState's ScrollAnimationMomentum into ScrollingEffectsController
Attachments
Patch
(11.68 KB, patch)
2021-09-23 17:23 PDT
,
Simon Fraser (smfr)
wenson_hsieh
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1
2021-09-23 17:23:50 PDT
Created
attachment 439109
[details]
Patch
Wenson Hsieh
Comment 2
2021-09-23 17:28:54 PDT
Comment on
attachment 439109
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=439109&action=review
> Source/WebCore/platform/ScrollingEffectsController.cpp:145 > + m_currentAnimation = WTF::makeUnique<ScrollAnimationMomentum>(*this);
Nit - you can omit this `WTF::`
Simon Fraser (smfr)
Comment 3
2021-09-23 22:08:04 PDT
https://trac.webkit.org/changeset/283026/webkit
Radar WebKit Bug Importer
Comment 4
2021-09-23 22:09:19 PDT
<
rdar://problem/83480219
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug