Cocoa port does this in it's platform initialization. It is no drawback when enabling this to all ports. Fields in parameters are already defined. Just not used in other ports than Cocoa.
This implementation: Source\WebKit\WebProcess\cocoa\WebProcessCocoa.mm > #if !LOG_DISABLED || !RELEASE_LOG_DISABLED > WebCore::initializeLogChannelsIfNecessary(parameters.webCoreLoggingChannels); > WebKit::initializeLogChannelsIfNecessary(parameters.webKitLoggingChannels); > #endif
<rdar://problem/83740947>
Created attachment 439813 [details] PATCH
Created attachment 439818 [details] PATCH
Comment on attachment 439818 [details] PATCH View in context: https://bugs.webkit.org/attachment.cgi?id=439818&action=review > Source/WebKit/WebProcess/WebProcess.cpp:-400 > - // Match the QoS of the UIProcess and the scrolling thread but use a slightly lower priority. This seems like a useful comment. Why delete it?
(In reply to Simon Fraser (smfr) from comment #5) > Comment on attachment 439818 [details] > PATCH > > View in context: > https://bugs.webkit.org/attachment.cgi?id=439818&action=review > > > Source/WebKit/WebProcess/WebProcess.cpp:-400 > > - // Match the QoS of the UIProcess and the scrolling thread but use a slightly lower priority. > > This seems like a useful comment. Why delete it? Ah, sorry that was accident. I'll revert the comment. Thanks.
Created attachment 439821 [details] PATCH
I think this change will break WebProcess logging of GTK, WPE and WinCairo because they don't set wtfLoggingChannels.
(In reply to Fujii Hironori from comment #8) > I think this change will break WebProcess logging of GTK, WPE and WinCairo > because they don't set wtfLoggingChannels. Oh, really? Hmm. It's safe to do this in PlayStation port, not moving it to shared. Thanks.
Created attachment 439923 [details] PATCH
Committed r283478 (242451@main): <https://commits.webkit.org/242451@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 439923 [details].