Bug 230724 - [LFC][IFC] InlineLevelBox only needs a handful of style properties
Summary: [LFC][IFC] InlineLevelBox only needs a handful of style properties
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-09-23 15:18 PDT by zalan
Modified: 2021-09-24 07:40 PDT (History)
5 users (show)

See Also:


Attachments
Patch (14.31 KB, patch)
2021-09-23 15:21 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (15.68 KB, patch)
2021-09-23 19:58 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2021-09-23 15:18:28 PDT
ssia
Comment 1 zalan 2021-09-23 15:21:09 PDT
Created attachment 439098 [details]
Patch
Comment 2 zalan 2021-09-23 19:58:17 PDT
Created attachment 439118 [details]
Patch
Comment 3 Antti Koivisto 2021-09-24 06:07:40 PDT
Comment on attachment 439118 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439118&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineLevelBox.h:133
> +    struct Style {
> +        const FontMetrics& primaryFontMetrics;
> +        const Length& lineHeight;
> +        InlineLayoutUnit primaryFontSize { 0 };
> +        VerticalAlignment verticalAlignment { };
> +    };
> +    Style m_style;

Nice
Comment 4 EWS 2021-09-24 07:39:11 PDT
Committed r283042 (242102@main): <https://commits.webkit.org/242102@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 439118 [details].
Comment 5 Radar WebKit Bug Importer 2021-09-24 07:40:21 PDT
<rdar://problem/83495963>