Bug 230722 - Stop using ALWAYS_LOG in media related classes
Summary: Stop using ALWAYS_LOG in media related classes
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-09-23 14:57 PDT by Basuke Suzuki
Modified: 2021-09-30 14:58 PDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Basuke Suzuki 2021-09-23 14:57:14 PDT
I don't know much about the history of media layer, but media related classes use ALWAYS_LOG helper macro. There are hundreds of logs per seconds while playing video. It's just too much.
Comment 1 Don Olmstead 2021-09-24 10:00:11 PDT
From talking to Eric Carlson it sounds like we'd want to look to see if this is specific to our implementation. `ALWAYS_LOG` should only be used for methods that are called periodically, while `DEBUG_LOG` is for methods that are called frequently.
Comment 2 Eric Carlson 2021-09-24 10:03:50 PDT
(In reply to Basuke Suzuki from comment #0)
> There are hundreds of logs per seconds while playing video. It's just too much.

This shouldn't be true, and definitely isn't the case in Apple's ports. 

`ALWAYS_LOG` is only supposed to be used in methods that are not called that frequently. What methods are being logged hundreds of times per second?
Comment 3 Basuke Suzuki 2021-09-24 11:47:10 PDT
(In reply to Eric Carlson from comment #2)
> (In reply to Basuke Suzuki from comment #0)
> > There are hundreds of logs per seconds while playing video. It's just too much.
> 
> This shouldn't be true, and definitely isn't the case in Apple's ports. 
> 
> `ALWAYS_LOG` is only supposed to be used in methods that are not called that
> frequently. What methods are being logged hundreds of times per second?

Really? Thanks for the info. I need double check my investigation. I'll let you know what I find then.
Comment 4 Radar WebKit Bug Importer 2021-09-30 14:58:19 PDT
<rdar://problem/83739434>