Bug 230722 – Stop using ALWAYS_LOG in media related classes

• Status: NEW
• Component: Media

[Basuke Suzuki]

I don't know much about the history of media layer, but media related classes use ALWAYS_LOG helper macro. There are hundreds of logs per seconds while playing video. It's just too much.

[Don Olmstead]

From talking to Eric Carlson it sounds like we'd want to look to see if this is specific to our implementation. `ALWAYS_LOG` should only be used for methods that are called periodically, while `DEBUG_LOG` is for methods that are called frequently.

[Eric Carlson]

(In reply to Basuke Suzuki from comment #0)
> There are hundreds of logs per seconds while playing video. It's just too much.

This shouldn't be true, and definitely isn't the case in Apple's ports. 

`ALWAYS_LOG` is only supposed to be used in methods that are not called that frequently. What methods are being logged hundreds of times per second?

[Basuke Suzuki]

(In reply to Eric Carlson from comment #2)
> (In reply to Basuke Suzuki from comment #0)
> > There are hundreds of logs per seconds while playing video. It's just too much.
> 
> This shouldn't be true, and definitely isn't the case in Apple's ports. 
> 
> `ALWAYS_LOG` is only supposed to be used in methods that are not called that
> frequently. What methods are being logged hundreds of times per second?

Really? Thanks for the info. I need double check my investigation. I'll let you know what I find then.

[Radar WebKit Bug Importer]

<rdar://problem/83739434>