Bug 23071 - REGRESSION (r39536): New test failures after committing patch in bug 23051 (ICU search)
Summary: REGRESSION (r39536): New test failures after committing patch in bug 23051 (I...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P1 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-01 19:53 PST by Simon Fraser (smfr)
Modified: 2009-01-01 20:47 PST (History)
1 user (show)

See Also:


Attachments
patch (5.47 KB, patch)
2009-01-01 20:41 PST, Darin Adler
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2009-01-01 19:53:34 PST
The fix for bug 23051 caused several new test failures:
http://build.webkit.org/results/trunk-mac-ppc-pixel/726/results.html

Most seem to be whitespace changes:
-This tests that a style that affects child elements when hovering over a parent element correctly recalculates the child style. To test manually move the mouse over the red square, it should become green.
+This tests that a style that affects child elements when hovering over a parent element correctly recalculates the child style.  To test manually move the mouse over the red square, it should become green.
Comment 1 Darin Adler 2009-01-01 20:13:06 PST
Oops! I think I can easily roll out the part of the patch that caused these.
Comment 2 Darin Adler 2009-01-01 20:13:27 PST
I could have sworn I ran the tests and didn't see those failures.
Comment 3 Darin Adler 2009-01-01 20:19:30 PST
I see exactly the mistake I made. The fix is very simple.
Comment 4 Darin Adler 2009-01-01 20:41:31 PST
Created attachment 26359 [details]
patch
Comment 5 Darin Adler 2009-01-01 20:47:44 PST
http://trac.webkit.org/changeset/39541