Bug 23069 – Generic section filtering with recessed buttons

• Status: RESOLVED
• Resolution: WONTFIX
• Component: Web Inspector (Deprecated)

[Konstantin Käfer]

Currently, there is a "Show Inherited" checkbox that allows the user to hide inherited styles. This mechanism is also useful for other things like hiding/showing DOM values etc. and should be generalized to PropertiesSection so that other parts can use it too. The filtering could be done with a recessed button to toggle filtering.

[Konstantin Käfer]

Created attachment 26356 [details]
illustrates the changes

[Konstantin Käfer]

Created attachment 26357 [details]
first patch iteration. see changelog in patch for further details

[Mark Rowe (bdash)]

The appearance of the "Inherited" button now seems to be that of a scope button.  Per <http://developer.apple.com/documentation/userexperience/Conceptual/AppleHIGuidelines/XHIGControls/chapter_19_section_3.html#//apple_ref/doc/uid/TP30000359-SW13> this doesn't seem like an appropriate use of a scope button, especially since doesn't *behave* like a scope button.  I don't understand the motivation for changing it in this fashion.

[Darin Adler]

Comment on attachment 26357 [details]
first patch iteration. see changelog in patch for further details

The screen shot seems to show two changes:

    1) the check box is changed into a button you can depress, one that looks like a Mac OS X "scope button"
    2) the layout of lines that overflow is better; the main title ends up on the top line and the subtitle ends up on second line, instead of backwards and truncating

Change (2) seems like a nice improvement.

Change (1) does not seem good. The check box makes more logical sense and we don't want something that looks like a "scope button" but doesn't act like one.

I'd rather that the main designer of the inspector UI, Tim Hatcher, comment here, but since Mark Rowe and I are both in agreement that we don't want (1) I'm going to say review- on this patch for now.