Bug 230686 – Replace Node::isInert() with RenderStyle::effectiveInert()

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Tim Nguyen (:ntim)]

The latter is less buggy, and one source of truth is always better.

[Tim Nguyen (:ntim)]

Created attachment 439043 [details]
Patch

[Tim Nguyen (:ntim)]

Created attachment 439053 [details]
Patch

[Tim Nguyen (:ntim)]

Created attachment 439263 [details]
Patch

[Antti Koivisto]

Comment on attachment 439263 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439263&action=review

> Source/WebCore/dom/Element.cpp:3537
> +    // FIXME: Replace inert/modal dialog logic with style->effectiveInert() after fixing invalidation
> +    auto elementHasInertAttribute = [](Element& element) -> bool {
> +        return element.document().settings().inertAttributeEnabled() && is<HTMLElement>(element) && element.hasAttribute(HTMLNames::inertAttr);
> +    };
> +
> +    if (elementHasInertAttribute(const_cast<Element&>(*this)))
> +        return false;
> +
> +    Node* activeModalDialog = document().activeModalDialog();
> +    if (activeModalDialog && !activeModalDialog->containsIncludingShadowDOM(this))
> +        return false;

This doesn't look correct. I can look at some point into resolving this correctly via style.

Meanwhile I think you should leave Node::isInert() equivalent in place (that is compute inertness separately from DOM) and use that in isFocusable() as before.

Or you could just let whatever focusability-with-inert-test you are trying to fix regress. It is probably not critical at this point.

[Tim Nguyen (:ntim)]

Created attachment 439336 [details]
Patch

[EWS]

Committed r283105 (242163@main): <https://commits.webkit.org/242163@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 439336 [details].

[Radar WebKit Bug Importer]

<rdar://problem/83568603>