Bug 230684 – LayoutTestFinder doesn't return tests in order

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Sam Sneddon [:gsnedders]]

It is clearly intended that LayoutTestFinder returns the tests in a deterministic order. But it doesn't actually do that: top-level directories appear in an arbitrary order.

Found while rewriting LayoutTestFinder and trying to compare my results against what we currently have.

[Sam Sneddon [:gsnedders]]

Created attachment 439069 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 439069 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439069&action=review

> Tools/ChangeLog:10
> +        running run-webkit-tests with no arguments ends up running the top-level directories in a

Is this a recent regression? In my experience, accessibility and animations always went first.

[Sam Sneddon [:gsnedders]]

(In reply to Alexey Proskuryakov from comment #2)
> Comment on attachment 439069 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=439069&action=review
> 
> > Tools/ChangeLog:10
> > +        running run-webkit-tests with no arguments ends up running the top-level directories in a
> 
> Is this a recent regression? In my experience, accessibility and animations
> always went first.

IIRC, it should in practice depend on the order the OS enumerates them (via libc).

[EWS]

Committed r283037 (242097@main): <https://commits.webkit.org/242097@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 439069 [details].

[Radar WebKit Bug Importer]

<rdar://problem/83493574>