When resolve min-length for auto repetitions, we need to consider transferred sizes from the aspect-ratio.
Created attachment 439026 [details] Patch
Comment on attachment 439026 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=439026&action=review Nice fix > Source/WebCore/rendering/RenderGrid.cpp:483 > + const Length& minSizeForTheOtherAxis = isRowAxis ? style().logicalMinHeight() : style().logicalMinWidth(); You can just use auto&. Also regarding the name I prefer minSizeForOrthogonalAxis, we've been using the "orthogonal" term for grid and flex extensively. > Source/WebCore/rendering/RenderGrid.cpp:484 > + if (!availableMaxSize && (!minSize.isSpecified() && (!minSizeForTheOtherAxis.isSpecified() || shouldIgnoreAspectRatio()))) I think you can remove the parentheses just before !minSize.isSpecified(). Also I think we can refactor the last condition into a variable and use it here and bellow. bool shouldComputeMinSizeFromAspectRatio = minSizeForTheOtherAxis.isSpecified() && !shouldIgnoreAspectRatio(); and then you'd use !shouldComputeMinSizeFromAspectRatio here and shouldComputeMinSizeAspectRatio in the else if block bellow.
Comment on attachment 439026 [details] Patch Forgot the r=me : )
Created attachment 439593 [details] Patch
<rdar://problem/83708927>
Committed r283321 (242346@main): <https://commits.webkit.org/242346@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 439593 [details].