Bug 230666 - Unify more media-related WebCore source files
Summary: Unify more media-related WebCore source files
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
Keywords: InRadar
Depends on:
Reported: 2021-09-22 21:34 PDT by Simon Fraser (smfr)
Modified: 2021-09-23 11:24 PDT (History)
10 users (show)

See Also:

Patch (68.15 KB, patch)
2021-09-22 21:35 PDT, Simon Fraser (smfr)
thorton: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2021-09-22 21:34:12 PDT
Unify more media-related WebCore source files
Comment 1 Simon Fraser (smfr) 2021-09-22 21:35:40 PDT
Created attachment 439011 [details]
Comment 2 Tim Horton 2021-09-22 23:11:22 PDT
Comment on attachment 439011 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=439011&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:-52
> -static const NSString *PlaybackSessionIdKey = @"PlaybackSessionID";

IIRC one of the other common semi-hacky answers was to stick (part of) the filename in it somewhere. Ideally of course it would come from some other file to avoid this problem...

> Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm:162
> -static bool isEqual(Uint8Array* data, const char* literal)
> +static bool isEqual2(Uint8Array* data, const char* literal)

Ditto the "maybe file name or some other context instead of weird suffixes"
Comment 3 EWS 2021-09-23 09:44:44 PDT
Tools/Scripts/svn-apply failed to apply attachment 439011 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Comment 4 Simon Fraser (smfr) 2021-09-23 11:23:25 PDT
Comment 5 Radar WebKit Bug Importer 2021-09-23 11:24:20 PDT