WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
230666
Unify more media-related WebCore source files
https://bugs.webkit.org/show_bug.cgi?id=230666
Summary
Unify more media-related WebCore source files
Simon Fraser (smfr)
Reported
2021-09-22 21:34:12 PDT
Unify more media-related WebCore source files
Attachments
Patch
(68.15 KB, patch)
2021-09-22 21:35 PDT
,
Simon Fraser (smfr)
thorton
: review+
ews-feeder
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1
2021-09-22 21:35:40 PDT
Created
attachment 439011
[details]
Patch
Tim Horton
Comment 2
2021-09-22 23:11:22 PDT
Comment on
attachment 439011
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=439011&action=review
> Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:-52 > -static const NSString *PlaybackSessionIdKey = @"PlaybackSessionID";
IIRC one of the other common semi-hacky answers was to stick (part of) the filename in it somewhere. Ideally of course it would come from some other file to avoid this problem...
> Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm:162 > -static bool isEqual(Uint8Array* data, const char* literal) > +static bool isEqual2(Uint8Array* data, const char* literal)
Ditto the "maybe file name or some other context instead of weird suffixes"
EWS
Comment 3
2021-09-23 09:44:44 PDT
Tools/Scripts/svn-apply failed to apply
attachment 439011
[details]
to trunk. Please resolve the conflicts and upload a new patch.
Simon Fraser (smfr)
Comment 4
2021-09-23 11:23:25 PDT
https://trac.webkit.org/changeset/282973/webkit
Radar WebKit Bug Importer
Comment 5
2021-09-23 11:24:20 PDT
<
rdar://problem/83457465
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug