Bug 23066 - Full Page Zoom: a <video> element that doesn't include width/height attribute does not scale
Summary: Full Page Zoom: a <video> element that doesn't include width/height attribute...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-01 12:02 PST by Eric Carlson
Modified: 2009-01-02 16:21 PST (History)
0 users

See Also:


Attachments
proposed fix (1.89 KB, patch)
2009-01-01 12:11 PST, Eric Carlson
darin: review+
Details | Formatted Diff | Diff
revised patch (5.44 KB, patch)
2009-01-02 12:32 PST, Eric Carlson
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2009-01-01 12:02:55 PST
A <video> element without width and height, like the following, doesn't scale as the page is zoomed with cmd +/-. It will scale properly if width and height attributes are added.

<html>
<head><title>video without width and height</title></head>
<body>
<p>Video element with no width and height specified</p>
<video src="http://pulsar.esm.psu.edu/Faculty/Gray/graphics/movies/colors00.mov" autoplay></video>
</body>
</html>
Comment 1 Eric Carlson 2009-01-01 12:11:04 PST
Created attachment 26349 [details]
proposed fix
Comment 2 Darin Adler 2009-01-01 12:50:54 PST
Comment on attachment 26349 [details]
proposed fix

Fix looks great, but we require a regression test for each fix. I don't know if we have regression test machinery yet for testing zoom.

I'm going to say r=me, but please investigate adding a regression test.
Comment 3 Eric Carlson 2009-01-02 12:32:29 PST
Created attachment 26378 [details]
revised patch

It looks like WebKit uses the same code path for css zoom and Safari cmd +/-, so the revised patch includes a layout test that sets 'zoom: 150%' on two video elements. The page renders incorrectly with TOT but does the right thing with the proposed changes to RenderVideo.cpp.
Comment 4 Darin Adler 2009-01-02 13:04:35 PST
Comment on attachment 26378 [details]
revised patch

r=me
Comment 5 Eric Carlson 2009-01-02 16:21:37 PST
Committed revision 39562.