In GitHub pull requests, we should linkify http urls. This includes both the code to generate the pull-request and the code parsing our existing pull-requests.
Pull-request: https://github.com/WebKit/WebKit/pull/10
Created attachment 439681 [details] Patch
<rdar://problem/83695409>
Comment on attachment 439681 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=439681&action=review > Tools/Scripts/libraries/webkitscmpy/webkitscmpy/pull_request.py:52 > + def escape_html(cls, message): out of curiosity why not use an escape library?
Comment on attachment 439681 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=439681&action=review >> Tools/Scripts/libraries/webkitscmpy/webkitscmpy/pull_request.py:52 >> + def escape_html(cls, message): > > out of curiosity why not use an escape library? I didn't find one that did exactly what we needed, because we don't need general HTML escaping (GitHub does quite a bit of the work for us), just some very specific cases to handle string like "<rdar://problem/1234">
Created attachment 439865 [details] Patch for landing
Committed r283373 (242381@main): <https://commits.webkit.org/242381@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 439865 [details].