Bug 230652 - [JSC] emoji and eor collations are missing
Summary: [JSC] emoji and eor collations are missing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-09-22 16:23 PDT by Yusuke Suzuki
Modified: 2021-10-01 16:43 PDT (History)
9 users (show)

See Also:

Attachments
Patch (5.79 KB, patch)
2021-09-22 16:24 PDT, Yusuke Suzuki 		ross.kirsling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2021-09-22 16:23:21 PDT 
[JSC] emoji and eor collations are missing
Comment 1 Yusuke Suzuki 2021-09-22 16:24:33 PDT 
Created attachment 438989 [details]
Patch
Comment 2 Ross Kirsling 2021-09-22 17:25:13 PDT 
Comment on attachment 438989 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438989&action=review

r=me with a question

> Source/JavaScriptCore/runtime/IntlObject.cpp:1661
> +    // ICU ~69 has a bug that does not report "emoji" and "eor" for collation when using ucol_getKeywordValues.

There's no concern for older ICU versions here, is there?
Comment 3 Yusuke Suzuki 2021-09-22 17:28:15 PDT 
Comment on attachment 438989 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438989&action=review

>> Source/JavaScriptCore/runtime/IntlObject.cpp:1661
>> +    // ICU ~69 has a bug that does not report "emoji" and "eor" for collation when using ucol_getKeywordValues.
> 
> There's no concern for older ICU versions here, is there?

Even though it is not supported, it is still OK to have that in available collations, since it just means that we have this collation, but no locale supports that.
Comment 4 Yusuke Suzuki 2021-09-22 17:39:31 PDT 
Committed r282897 (242025@main): <https://commits.webkit.org/242025@main>
Comment 5 Radar WebKit Bug Importer 2021-09-22 17:40:28 PDT 
<rdar://problem/83425179>
Comment 6 Darin Adler 2021-10-01 16:43:57 PDT 
Comment on attachment 438989 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438989&action=review

> Source/JavaScriptCore/runtime/IntlObject.cpp:1688
> +    elements.resize(elements.size() - (elements.end() - end));

Not important, but for slightly more efficient code this can use shrink instead of resize.