Bug 230642 - Turn WebCore::LineCap and WebCore::LineJoin into 8-bit enum classes
Summary: Turn WebCore::LineCap and WebCore::LineJoin into 8-bit enum classes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-09-22 14:37 PDT by Wenson Hsieh
Modified: 2021-09-22 21:32 PDT (History)
19 users (show)

See Also:

Attachments
Patch (20.11 KB, patch)
2021-09-22 16:09 PDT, Wenson Hsieh 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
For EWS (24.10 KB, patch)
2021-09-22 16:30 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
For EWS (24.80 KB, patch)
2021-09-22 18:48 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2021-09-22 14:37:09 PDT 
Some self-contained refactoring, en route to larger changes around the concurrent display list processing model.
Comment 1 Wenson Hsieh 2021-09-22 16:09:45 PDT Comment hidden (obsolete)
Comment 2 Wenson Hsieh 2021-09-22 16:30:05 PDT 
Created attachment 438990 [details]
For EWS
Comment 3 Simon Fraser (smfr) 2021-09-22 17:44:59 PDT 
Comment on attachment 438990 [details]
For EWS

View in context: https://bugs.webkit.org/attachment.cgi?id=438990&action=review

> Source/WebCore/platform/graphics/GraphicsTypes.h:93
>      ButtCap,
>      RoundCap,
>      SquareCap

Butt, Round, Square

> Source/WebCore/platform/graphics/GraphicsTypes.h:99
>      MiterJoin,
>      RoundJoin,
>      BevelJoin

Miter, Round, Bevel.
Comment 4 Wenson Hsieh 2021-09-22 17:56:40 PDT 
Comment on attachment 438990 [details]
For EWS

View in context: https://bugs.webkit.org/attachment.cgi?id=438990&action=review

Thanks for the review.

>> Source/WebCore/platform/graphics/GraphicsTypes.h:93
>>      SquareCap
> 
> Butt, Round, Square

Fixed!

>> Source/WebCore/platform/graphics/GraphicsTypes.h:99
>>      BevelJoin
> 
> Miter, Round, Bevel.

👍🏻
Comment 5 Wenson Hsieh 2021-09-22 18:48:53 PDT 
Created attachment 439003 [details]
For EWS
Comment 6 EWS 2021-09-22 21:30:57 PDT 
Committed r282920 (242034@main): <https://commits.webkit.org/242034@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 439003 [details].
Comment 7 Radar WebKit Bug Importer 2021-09-22 21:32:15 PDT 
<rdar://problem/83431075>