Bug 230631 - Add checkScriptSyntax function to jsc host environment
Summary: Add checkScriptSyntax function to jsc host environment
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-09-22 10:00 PDT by Rick Waldron
Modified: 2021-09-24 15:14 PDT (History)
8 users (show)

See Also:


Attachments
Patch (23.89 KB, patch)
2021-09-24 09:06 PDT, Rick Waldron
no flags Details | Formatted Diff | Diff
Patch (23.91 KB, patch)
2021-09-24 11:40 PDT, Rick Waldron
no flags Details | Formatted Diff | Diff
Patch (23.92 KB, patch)
2021-09-24 11:45 PDT, Rick Waldron
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rick Waldron 2021-09-22 10:00:25 PDT
In jsc.cpp, there is currently checkSyntax() and checkModuleSyntax(). The former expects and filename, while the latter expects a string of javascript code. This would introduce a function called checkScriptSyntax() that performed the same operation as checkModuleSyntax(), without the module specific semantics.
Comment 1 Rick Waldron 2021-09-24 09:06:55 PDT
Created attachment 439153 [details]
Patch
Comment 2 Yusuke Suzuki 2021-09-24 11:29:40 PDT
Comment on attachment 439153 [details]
Patch

r=me
Comment 3 EWS 2021-09-24 11:30:39 PDT
? found in /Volumes/Data/worker/Commit-Queue/build/JSTests/ChangeLog does not appear to be a valid reviewer according to contributors.json.
/Volumes/Data/worker/Commit-Queue/build/JSTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
Comment 4 Yusuke Suzuki 2021-09-24 11:34:08 PDT
Comment on attachment 439153 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439153&action=review

Setting r- since ChangeLog file is not correct.

> Source/JavaScriptCore/ChangeLog:6
> +        Reviewed by ?.

Default line is necessary for commit-queue. https://webkit.org/contributing-code/#changelog-files
You can check the instructions of contribution in https://webkit.org/contributing-code/ :)
Comment 5 Rick Waldron 2021-09-24 11:39:47 PDT
I didn't know if I should put a name before I got the actual review ;)
Comment 6 Rick Waldron 2021-09-24 11:40:52 PDT
Created attachment 439176 [details]
Patch
Comment 7 Rick Waldron 2021-09-24 11:45:56 PDT
Created attachment 439178 [details]
Patch
Comment 8 EWS 2021-09-24 15:13:11 PDT
Committed r283062 (242120@main): <https://commits.webkit.org/242120@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 439178 [details].
Comment 9 Radar WebKit Bug Importer 2021-09-24 15:14:19 PDT
<rdar://problem/83513547>